Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use ubuntu 22.04 for tests #13377

Merged
merged 4 commits into from
Dec 19, 2024
Merged

build: use ubuntu 22.04 for tests #13377

merged 4 commits into from
Dec 19, 2024

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Dec 19, 2024

This PR resolves the following issue when running Python 3.7 tests :

  Version 3.7 was not found in the local cache
  Error: The version '3.7' with architecture 'x64' was not found for Ubuntu 24.04.

@parthea parthea marked this pull request as ready for review December 19, 2024 12:22
@parthea parthea requested a review from a team as a code owner December 19, 2024 12:22
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 19, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 19, 2024
@@ -13,7 +13,9 @@ permissions:

jobs:
unit:
runs-on: ubuntu-latest
# Use ubuntu-22.04 until Python 3.7 is removed from the test matrix
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a TODO and link to an umbrella issue for this? A quick search suggests the only currently filed issue for the 3.7 deprecation is #11437, but that deals more with messaging the deprecation. We should have an issue for actually removing support when the time comes, and part of that should be removing this Ubuntu specification.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 84387ef

@parthea parthea enabled auto-merge (squash) December 19, 2024 20:56
@parthea parthea merged commit 9b2f079 into main Dec 19, 2024
18 checks passed
@parthea parthea deleted the use-ubuntu-2204 branch December 19, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants