-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Bigtable RowFilter base class. #1291
Conversation
@tseaver I'm going to start with just two here. |
15b001d
to
559772b
Compare
@tseaver PTAL. I opted not to have regex filters inherit from a parent, but these ended up having also identical unit tests, so maybe it would've been worth it? I figured it was unnecessary since the classes to so little. (FWIW of the 19 filters, 4 of them are regex filters) |
If four of the filters take only a |
OK. Will re-factor. |
559772b
to
e1fe6a4
Compare
@tseaver PTAL. I added |
return False | ||
return other.regex == self.regex | ||
|
||
def to_pb(self): |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Also adding regex filters for a row key (bytes) and a family name (string). These come from https://github.com/GoogleCloudPlatform/cloud-bigtable-client/blob/6a498cd3e660c7ed18299e980c1658d67661e69b/bigtable-protos/src/main/proto/google/bigtable/v1/bigtable_data.proto#L321-L404 In addition to more classes for primitive properties, parent classes are forthcoming to handle the non-primitive cases of filter Chain, Interleave and Condition (ternary). Also renaming some redunant unit test names in test_column_family.py and ditching use of NotImplementedError in bigtable base classes (for both GC rule and row filter).
e1fe6a4
to
e3c046f
Compare
@tseaver PTAL I dropped all the virtual |
LGTM |
Adding Bigtable RowFilter base class.
Also adding regex filters for a row key (bytes) and a family name (string).
These come from
https://github.com/GoogleCloudPlatform/cloud-bigtable-client/blob/6a498cd3e660c7ed18299e980c1658d67661e69b/bigtable-protos/src/main/proto/google/bigtable/v1/bigtable_data.proto#L321-L404
In addition to more classes for primitive properties, parent classes are forthcoming to handle the non-primitive cases of filter Chain, Interleave and Condition (ternary).
Also renaming some redunant unit test names in
test_column_family.py
and ditching use ofNotImplementedError
in bigtable base classes (for both GC rule and row filter).