-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding primitive Bigtable garbage collection rule classes. #1290
Conversation
.. note:: | ||
|
||
At most one of ``max_num_versions`` and ``max_age`` can be specified | ||
at once. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
I am assuming (and am re-implementing under the assumption) that you are more in favor of 13+ subclasses than a class with 13+ arguments (for the filter case). (Here it's simpler since there are only two options.) |
Exactly, because their implementations will be super-simple / obvious. For the filters, It is also a lot clearer to map the separate classes onto a "syntax tree" when we get around to intersection / union logic. |
These are used as settings when creating new column families within a table. Also slipping in 3 small Bigtable docstring updates.
4e3f599
to
92f196d
Compare
Looks like https://pypi.python.org/pypi/protobuf/3.0.0b1.post1 (released today) caused Travis to fail:
|
Caused by a breakage in latest protobuf release (3.0.0b1.post1).
@tseaver I filed protocolbuffers/protobuf#1056 and pinned to |
Shouldn't we remove that version, and replace it with the new one in Other than that, LGTM. |
@tseaver It's not used anymore, I just remembered we had it before we put all time related stuff in |
Adding primitive Bigtable garbage collection rule classes.
These are used as settings when creating new column
families within a table.
Also slipping in 3 small Bigtable docstring updates.