Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that gRPC metrics headers are in the order requested by the spec. #4068

Closed
theacodes opened this issue Sep 26, 2017 · 3 comments
Closed
Assignees
Labels
api: core priority: p2 Moderately-important priority. Fix may not be included in next release.

Comments

@theacodes
Copy link
Contributor

The present order in api.core is:

core/0.27.1 gl-python/3.6.0 grpc/0.27.1 gapic/0.27.2

The order per spec should be:

gl-python/2.7.12 gccl/0.21.0 gapic/0.1.0 core/0.14.1 grpc/1.0.1
@theacodes theacodes added api: core priority: p2 Moderately-important priority. Fix may not be included in next release. labels Sep 26, 2017
@theacodes theacodes self-assigned this Sep 26, 2017
@lukesneeringer
Copy link
Contributor

And core should be spelled gax.

@theacodes
Copy link
Contributor Author

@theacodes
Copy link
Contributor Author

Part of me kind of wants to sit on this until intercepters are ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: core priority: p2 Moderately-important priority. Fix may not be included in next release.
Projects
None yet
Development

No branches or pull requests

2 participants