-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jobs] testing: use multiple projects #4068
[jobs] testing: use multiple projects #4068
Conversation
24fb012
to
5a049c2
Compare
import uuid | ||
|
||
from google.cloud import talent | ||
import pytest | ||
|
||
import job_search_list_tenants | ||
|
||
PROJECT_ID = os.environ["GOOGLE_CLOUD_PROJECT"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this env var is commented out in the noxfile_config.py, Does it get assigned from somewhere else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not commenting out :)
Long story, but we're copying noxfile-template.py
at the project root directory to noxfile.py
, and use it for driving the test.
noxfile.py will override the values set by the build config files (e.g. py-3.6 config)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see
LGMT! |
@gguuss would you please take a look this? Looks like my Approval is not legit enough :') |
…ython-docs-samples#4068) * [jobs] testing: use multiple projects * added README
…ython-docs-samples#4068) * [jobs] testing: use multiple projects * added README
…ython-docs-samples#4068) * [jobs] testing: use multiple projects * added README
fixes #4061