Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jobs] testing: use multiple projects #4068

Merged
merged 4 commits into from
Jun 12, 2020

Conversation

tmatsuo
Copy link
Contributor

@tmatsuo tmatsuo commented Jun 11, 2020

fixes #4061

@tmatsuo tmatsuo requested a review from a team as a code owner June 11, 2020 21:29
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 11, 2020
import uuid

from google.cloud import talent
import pytest

import job_search_list_tenants

PROJECT_ID = os.environ["GOOGLE_CLOUD_PROJECT"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this env var is commented out in the noxfile_config.py, Does it get assigned from somewhere else?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not commenting out :)

Long story, but we're copying noxfile-template.py at the project root directory to noxfile.py, and use it for driving the test.

noxfile.py will override the values set by the build config files (e.g. py-3.6 config)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see

@munkhuushmgl
Copy link
Contributor

LGMT!

@munkhuushmgl
Copy link
Contributor

@gguuss would you please take a look this? Looks like my Approval is not legit enough :')

@tmatsuo tmatsuo merged commit fe463a3 into GoogleCloudPlatform:master Jun 12, 2020
@tmatsuo tmatsuo deleted the jobs-multi-projects branch June 12, 2020 18:54
busunkim96 pushed a commit to busunkim96/python-talent that referenced this pull request Sep 24, 2020
busunkim96 pushed a commit to googleapis/python-talent that referenced this pull request Sep 25, 2020
xtineskim pushed a commit that referenced this pull request Nov 11, 2022
* [jobs] testing: use multiple projects

* added README
dandhlee pushed a commit that referenced this pull request Nov 14, 2022
* [jobs] testing: use multiple projects

* added README
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[jobs] use multiple projects
4 participants