Move shared testing code into core

composer.json

@@ -103,9 +103,6 @@
             "Google\\Cloud\\Tests\\System\\": "tests/system",
             "Google\\Cloud\\Tests\\Unit\\": "tests/unit"
         },
-        "files": [
-            "dev/src/Functions.php"
-        ],
         "classmap": [
             "tests/conformance-fixtures"
         ]
@@ -127,4 +124,4 @@
             ]
         }
     }
-}
+}

tests/ArrayHasSameValuesToken.php → src/Core/Testing/ArrayHasSameValuesToken.php

@@ -1,6 +1,6 @@
 <?php
 
-namespace Google\Cloud\Tests;
+namespace Google\Cloud\Core\Testing;
 
 use Prophecy\Argument\Token\TokenInterface;
 use Prophecy\Util\StringUtil;

src/Core/Testing/Functions.php

@@ -0,0 +1,78 @@
+<?php
+
+/**
+ * Copyright 2017 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+namespace Google\Cloud\Core\Testing;
+
+class Functions
+{
+    /**
+     * Create a test stub which extends a real class and allows overriding of private properties.
+     *
+     * @param string $extends The fully-qualified name of the class to extend.
+     * @param array $args An array of constructor arguments to use when creating the stub.
+     * @param array $props A list of private properties on which to enable overrriding.
+     * @return mixed
+     */
+    public static function stub($extends, array $args = [], array $props = [])
+    {
+        if (empty($props)) {
+            $props = ['connection'];
+        }
+
+        $tpl = 'class %s extends %s {private $___props = \'%s\'; use \Google\Cloud\Dev\StubTrait; }';
+
+        $name = 'Stub' . sha1($extends);
+
+        if (!class_exists($name)) {
+            eval(sprintf($tpl, $name, $extends, json_encode($props)));
+        }
+
+        $reflection = new \ReflectionClass($name);
+        return $reflection->newInstanceArgs($args);
+    }
+
+    /**
+     * Get a trait implementation.
+     *
+     * @param string $trait The fully-qualified name of the trait to implement.
+     * @return mixed
+     */
+    public static function impl($trait, array $props = [])
+    {
+        $properties = [];
+        foreach ($props as $prop) {
+            $properties[] = 'private $' . $prop . ';';
+        }
+
+        $tpl = 'class %s {
+            use %s;
+            use \Google\Cloud\Dev\StubTrait;
+            private $___props = \'%s\';
+            %s
+            public function call($fn, array $args = []) { return call_user_func_array([$this, $fn], $args); }
+        }';
+
+        $name = 'Trait' . sha1($trait . json_encode($props));
+
+        if (!class_exists($name)) {
+            eval(sprintf($tpl, $name, $trait, json_encode($props), implode("\n", $properties)));
+        }
+
+        return new $name;
+    }
+}

tests/GrpcTestTrait.php → src/Core/Testing/GrpcTestTrait.php

@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-namespace Google\Cloud\Tests;
+namespace Google\Cloud\Core\Testing;
 
 /**
  * Provides checks for whether to run gRPC tests

tests/KeyPairGenerateTrait.php → src/Core/Testing/KeyPairGenerateTrait.php

@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-namespace Google\Cloud\Tests;
+namespace Google\Cloud\Core\Testing;
 
 use Google\Cloud\Storage\EncryptionTrait;
 use phpseclib\Crypt\RSA;

src/Core/Testing/Lock/Functions.php

@@ -0,0 +1,21 @@
+<?php
+
+/**
+ * Copyright 2017 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+use Google\Cloud\Core\Testing\Lock\MockValues;
+
+

tests/unit/Core/Lock/MockGlobals.php → src/Core/Testing/Lock/MockGlobals.php

@@ -1,6 +1,23 @@
 <?php
 
+/**
+ * Copyright 2017 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
 namespace Google\Cloud\Core\Lock {
+
     class MockValues
     {
         public static $flockReturnValue;
@@ -12,17 +29,18 @@ class MockValues
         public static function initialize()
         {
             self::$flockReturnValue = true;
-            self::$fopenReturnValue = function($file, $mode) {
+            self::$fopenReturnValue = function ($file, $mode) {
                 return \fopen($file, $mode);
             };
             self::$sem_acquireReturnValue = true;
             self::$sem_releaseReturnValue = true;
-            self::$sem_getReturnValue = function($key) {
+            self::$sem_getReturnValue = function ($key) {
                 return \sem_get($key);
             };
         }
     }
 
+
     function flock($handle, $type)
     {
         return MockValues::$flockReturnValue;

dev/src/Snippet/SnippetTestCase.php → src/Core/Testing/Snippet/SnippetTestCase.php

@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-namespace Google\Cloud\Dev\Snippet;
+namespace Google\Cloud\Core\Testing\Snippet;
 
 use Google\Cloud\Dev\Snippet\Container;
 use PHPUnit\Framework\TestCase;

tests/system/DeletionQueue.php → src/Core/Testing/System/DeletionQueue.php

@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-namespace Google\Cloud\Tests\System;
+namespace Google\Cloud\Core\Testing\System;
 
 use Google\Cloud\Core\Exception\NotFoundException;
 use Google\Cloud\Core\ExponentialBackoff;

tests/system/SystemTestCase.php → src/Core/Testing/System/SystemTestCase.php

@@ -15,13 +15,13 @@
  * limitations under the License.
  */
 
-namespace Google\Cloud\Tests\System;
+namespace Google\Cloud\Core\Testing\System;
 
 use Google\Cloud\BigQuery\BigQueryClient;
 use Google\Cloud\Core\ExponentialBackoff;
 use Google\Cloud\PubSub\PubSubClient;
 use Google\Cloud\Storage\StorageClient;
-use Google\Cloud\Tests\System\DeletionQueue;
+use Google\Cloud\Core\Testing\System\DeletionQueue;
 use PHPUnit\Framework\TestCase;
 
 class SystemTestCase extends TestCase

tests/conformance/FirestoreTest.php

@@ -63,7 +63,7 @@ class FirestoreTest extends TestCase
 
     public function setUp()
     {
-        $this->client = \Google\Cloud\Dev\stub(FirestoreClient::class, [
+        $this->client = \Google\Cloud\Core\Testing\Functions::stub(FirestoreClient::class, [
             [
                 'projectId' => 'projectID'
             ]

tests/snippets/BigQuery/BigQueryClientTest.php

@@ -30,7 +30,7 @@
 use Google\Cloud\BigQuery\ValueMapper;
 use Google\Cloud\Core\Int64;
 use Google\Cloud\Core\Iterator\ItemIterator;
-use Google\Cloud\Dev\Snippet\SnippetTestCase;
+use Google\Cloud\Core\Testing\Snippet\SnippetTestCase;
 use Prophecy\Argument;
 
 /**
@@ -70,7 +70,7 @@ class BigQueryClientTest extends SnippetTestCase
     public function setUp()
     {
         $this->connection = $this->prophesize(ConnectionInterface::class);
-        $this->client = \Google\Cloud\Dev\stub(BigQueryTestClient::class);
+        $this->client = \Google\Cloud\Core\Testing\Functions::stub(BigQueryTestClient::class);
         $this->client->___setProperty('connection', $this->connection->reveal());
     }
 

tests/snippets/BigQuery/BytesTest.php

@@ -18,7 +18,7 @@
 namespace Google\Cloud\Tests\Snippets\BigQuery;
 
 use Google\Cloud\BigQuery\Bytes;
-use Google\Cloud\Dev\Snippet\SnippetTestCase;
+use Google\Cloud\Core\Testing\Snippet\SnippetTestCase;
 use Prophecy\Argument;
 
 /**

tests/snippets/BigQuery/CopyJobConfigurationTest.php

@@ -19,7 +19,7 @@
 
 use Google\Cloud\BigQuery\BigQueryClient;
 use Google\Cloud\BigQuery\CopyJobConfiguration;
-use Google\Cloud\Dev\Snippet\SnippetTestCase;
+use Google\Cloud\Core\Testing\Snippet\SnippetTestCase;
 
 /**
  * @group bigquery
@@ -70,7 +70,7 @@ public function testSetters($method, $expected, $bq = null)
 
     public function setterDataProvider()
     {
-        $bq = \Google\Cloud\Dev\stub(BigQueryClient::class, [
+        $bq = \Google\Cloud\Core\Testing\Functions::stub(BigQueryClient::class, [
             ['projectId' => self::PROJECT_ID]
         ]);
 

tests/snippets/BigQuery/DatasetTest.php

@@ -22,7 +22,7 @@
 use Google\Cloud\BigQuery\Table;
 use Google\Cloud\BigQuery\ValueMapper;
 use Google\Cloud\Core\Iterator\ItemIterator;
-use Google\Cloud\Dev\Snippet\SnippetTestCase;
+use Google\Cloud\Core\Testing\Snippet\SnippetTestCase;
 use Prophecy\Argument;
 
 /**

tests/snippets/BigQuery/DateTest.php

@@ -18,7 +18,7 @@
 namespace Google\Cloud\Tests\Snippets\BigQuery;
 
 use Google\Cloud\BigQuery\Date;
-use Google\Cloud\Dev\Snippet\SnippetTestCase;
+use Google\Cloud\Core\Testing\Snippet\SnippetTestCase;
 use Prophecy\Argument;
 
 /**

tests/snippets/BigQuery/ExtractJobConfigurationTest.php

@@ -20,7 +20,7 @@
 use Google\Cloud\BigQuery\BigQueryClient;
 use Google\Cloud\BigQuery\ExtractJobConfiguration;
 use Google\Cloud\BigQuery\Table;
-use Google\Cloud\Dev\Snippet\SnippetTestCase;
+use Google\Cloud\Core\Testing\Snippet\SnippetTestCase;
 
 /**
  * @group bigquery
@@ -71,7 +71,7 @@ public function testSetters($method, $expected, $bq = null)
 
     public function setterDataProvider()
     {
-        $bq = \Google\Cloud\Dev\stub(BigQueryClient::class, [
+        $bq = \Google\Cloud\Core\Testing\Functions::stub(BigQueryClient::class, [
             ['projectId' => self::PROJECT_ID]
         ]);
 

tests/snippets/BigQuery/InsertResponseTest.php

@@ -18,7 +18,7 @@
 namespace Google\Cloud\Tests\Snippets\BigQuery;
 
 use Google\Cloud\BigQuery\InsertResponse;
-use Google\Cloud\Dev\Snippet\SnippetTestCase;
+use Google\Cloud\Core\Testing\Snippet\SnippetTestCase;
 use Prophecy\Argument;
 
 /**

tests/snippets/BigQuery/JobTest.php

@@ -21,7 +21,7 @@
 use Google\Cloud\BigQuery\Job;
 use Google\Cloud\BigQuery\QueryResults;
 use Google\Cloud\BigQuery\ValueMapper;
-use Google\Cloud\Dev\Snippet\SnippetTestCase;
+use Google\Cloud\Core\Testing\Snippet\SnippetTestCase;
 use Prophecy\Argument;
 
 /**