Move shared testing code into core #822

michaelbausor · 2017-12-28T17:24:46Z

This PR starts the process of migrating google-cloud-php to a new structure. The first step is to make sure that all shared code, in particular code for testing, is included in the google/cloud-core, so that a standalone repo can depend on google/cloud-core and be able to support its own tests.

tests/unit/Spanner/Session/CacheSessionPoolTest.php

@@ -17,15 +17,14 @@

 namespace Google\Cloud\Tests\Unit\Spanner\Session;

-require_once __DIR__ . '../../../Core/Lock/MockGlobals.php';
+require_once __DIR__ . '/../../../../src/Core/Testing/Lock/MockGlobals.php';


michaelbausor · 2017-12-28T17:27:31Z

Note that in theory this change is non-breaking and can be merged/released without the remaining restructuring work

src/Core/Testing/Functions.php

+ * @experimental
+ * @internal
+ */
+class Functions


tests/snippets/Core/Iam/IamTest.php

        $this->iam->___setProperty('connection', $this->connection->reveal());
    }

    public function testClass()
    {
        $snippet = $this->snippetFromClass(Iam::class);
+        $this->checkAndSkipTest([
+            '\Google\Cloud\PubSub\PubSubClient',


dwsupplee

There are some really nice changes in here. Great work!

Could we exclude Core\Testing from out unit test coverage?

src/Core/Testing/Functions.php

+ * @experimental
+ * @internal
+ */
+class Functions


tests/unit/Core/Fixtures.php

+        return __DIR__ . '/fixtures/json-key-fixture.json';
+    }
+
+    public static function  SERVICE_FIXTURE()


tests/unit/Core/Fixtures.php

@@ -0,0 +1,31 @@
+<?php
+/**
+ * Copyright 2017 Google Inc.


tests/unit/Datastore/Fixtures.php

@@ -0,0 +1,46 @@
+<?php
+/**
+ * Copyright 2017 Google Inc.


tests/unit/Spanner/Fixtures.php

@@ -0,0 +1,31 @@
+<?php
+/**
+ * Copyright 2017 Google Inc.


tests/unit/Vision/Fixtures.php

@@ -0,0 +1,31 @@
+<?php
+/**
+ * Copyright 2017 Google Inc.


michaelbausor · 2018-01-31T20:56:26Z

Updated, PTAL

dwsupplee · 2018-01-31T21:23:59Z

@michaelbausor it looks like there are a few files that need Functions to be updated to TestHelpers.

michaelbausor · 2018-01-31T21:48:31Z

Thanks - updated.

michaelbausor added 12 commits December 22, 2017 15:10

manual changes

8143806

Grpc trait rename

d7742e4

Rename key storage trait

e267e07

Rename stub

233156e

Rename impl

f393c70

Rename snippet tests

da1dc86

Rename stub

902be47

Rename SystemTestCase

307f0ed

Rename DeletionQueue

44a1c7e

Move fixtures

7029491

Rename stub and impl

d589514

Fix locking and fixtures

6d52f27

michaelbausor requested a review from jdpedrie as a code owner December 28, 2017 17:24

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 28, 2017

michaelbausor commented Dec 28, 2017

View reviewed changes

Fixes

a1f8aec

dwsupplee mentioned this pull request Jan 2, 2018

BigQuery Data Transfer: No PHP docs #826

Closed

michaelbausor added 12 commits January 5, 2018 10:30

Merge branch 'master' into move-shared-into-core

e5c3569

Restructure MockGlobals, update fixtures

0b0f30e

Fix phpcs errors

84b2b22

Fix snippet tests

d929d42

Merge branch 'master' into move-shared-into-core

2669893

Add comments to support doc building

668295a

Exclude MockValues from side effects phpcs rule

75722a2

Update StubTrait

7134422

Remove Storage dependency from StreamableUploaderTest

e7b1fc7

Move code out of dev

71cb2b0

Add snippet testing of parser

4f87b74

Update Iam

e8751c3

michaelbausor added 4 commits January 11, 2018 09:53

Handle servicebuilder tests

520cf29

Add internal and experimental annotations

e76b08f

Add README to testing directory

c6e4837

Merge branch 'master' into move-shared-into-core

9673c49

michaelbausor changed the title ~~WIP: Move shared testing code into core~~ Move shared testing code into core Jan 11, 2018

michaelbausor added 5 commits January 11, 2018 16:15

Fix phpcs errors

a60255b

Fix import for doc gen

c2d88c3

Add comments to new code in Core/Testing

5a9d835

Merge branch 'master' into move-shared-into-core

d74c478

Update after merge

da17de0

jdpedrie reviewed Jan 29, 2018

View reviewed changes

michaelbausor added 4 commits January 30, 2018 10:19

Merge branch 'master' into move-shared-into-core

a8e503a

Address PR comments

19b6867

Merge branch 'master' into move-shared-into-core

803368d

Fix reference to impl

5f6d92a

dwsupplee suggested changes Jan 31, 2018

View reviewed changes

michaelbausor added 3 commits January 31, 2018 12:53

Address PR feedback

ec12d53

Exclude Core/Testing from unit tests

e98e0c6

Remove extra space

a12ce04

dwsupplee approved these changes Jan 31, 2018

View reviewed changes

michaelbausor added 2 commits January 31, 2018 13:26

Merge branch 'master' into move-shared-into-core

d99d600

Rename Functions to TestHelpers

8200a4b

dwsupplee merged commit b84cfd6 into googleapis:master Jan 31, 2018

jdpedrie mentioned this pull request Feb 1, 2018

Prepare v0.53.0 #879

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move shared testing code into core #822

Move shared testing code into core #822

michaelbausor commented Dec 28, 2017

This comment was marked as spam.

michaelbausor commented Dec 28, 2017

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

dwsupplee left a comment

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

michaelbausor commented Jan 31, 2018

dwsupplee commented Jan 31, 2018

michaelbausor commented Jan 31, 2018

Move shared testing code into core #822

Move shared testing code into core #822

Conversation

michaelbausor commented Dec 28, 2017

This comment was marked as spam.

michaelbausor commented Dec 28, 2017

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

dwsupplee left a comment

Choose a reason for hiding this comment

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

michaelbausor commented Jan 31, 2018

dwsupplee commented Jan 31, 2018

michaelbausor commented Jan 31, 2018