feat: move common-protos to the monorepo #7554
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the package
google/common-protos
(https://github.com/googleapis/common-protos-php) over to the monorepo.Renames the existing
CommonProtos
repo toCloudCommonProtos
, and usesCommonProtos
as the directory for the common protos for all APIs.This has the following advantages:
NOTE: I have configured this to use the same repo (
googleapis/common-protos-php
), but the first push will require a--force
, and will erase the history. I've tested this in composer, and upgrading to the new version / downgrading to the old one was not affected by rewriting the history, so this should not affect our users.NOTE: This is definitely more of a
chore
than afeat
, but I'd like to increment the version number to0.5