Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support google/protobuf 4 in googleapis/common-protos-php #7605

Closed
leongersen opened this issue Aug 15, 2024 · 3 comments
Closed

Support google/protobuf 4 in googleapis/common-protos-php #7605

leongersen opened this issue Aug 15, 2024 · 3 comments

Comments

@leongersen
Copy link

leongersen commented Aug 15, 2024

#7201 in this repository allows setting the dependency for google/protobuf to ^v3.25.3||^4.26.1.

This is not reflected in the released package for googleapis/common-protos-php. The composer.json for that package still depends on google/protobuf ^3.6.1.

@leongersen
Copy link
Author

This was correct until this commit, which references #7554.

#7580 reports another issue with this merge, which was fixed in #7591.

@kellerjmrtn
Copy link

Having a similar issue in my app, can't upgrade googleapis/common-protos-php to the latest versions because my app also requires google/protobuf:^4, and ^4 support seems to have dropped in the latest version

@bshaffer
Copy link
Contributor

bshaffer commented Sep 9, 2024

This is fixed in #7648 and in version 4.8.3 of google/common-protos

thanks for reporting this!

@bshaffer bshaffer closed this as completed Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants