Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: promote Workflows to stable and drop V1beta1 #7543

Merged
merged 2 commits into from
Jul 24, 2024
Merged

chore: promote Workflows to stable and drop V1beta1 #7543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e9c8bc
WIP
bshaffer Jul 23, 2024
26a4799
updates from owlbot
bshaffer Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Workflows/.OwlBot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
deep-copy-regex:
- source: /google/cloud/workflows/(v1|v1beta)/.*-php/(.*)
- source: /google/cloud/workflows/(v1)/.*-php/(.*)
dest: /owl-bot-staging/Workflows/$1/$2
- source: /google/cloud/workflows/executions/(v1|v1beta)/.*-php/(.*)
- source: /google/cloud/workflows/executions/(v1)/.*-php/(.*)
dest: /owl-bot-staging/Workflows/Executions/$1/$2
api-name: Workflows
Binary file removed Workflows/metadata/Executions/V1Beta/Executions.php
View file
Open in desktop
Binary file not shown.
Binary file removed Workflows/metadata/V1Beta/Workflows.php
View file
Open in desktop
Binary file not shown.
55 changes: 27 additions & 28 deletions Workflows/owlbot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,34 +41,33 @@
]
)

for version in ['v1', 'v1beta']:
executions_library = Path(f"../{php.STAGING_DIR}/Workflows/Executions/{version}").resolve()

# copy all src including partial veneer classes
s.move(
executions_library / 'src',
'src/Executions',
merge=preserve_copyright_year,
)
# copy proto files to src also
s.move(
executions_library / 'proto/src/Google/Cloud/Workflows',
'src/',
merge=preserve_copyright_year,
excludes=[
executions_library / "**/*_*.php"
]
)
s.move(
executions_library / 'tests/Unit',
'tests/Unit/Executions',
merge=preserve_copyright_year,
)
# copy GPBMetadata file to metadata
s.move(executions_library / 'proto/src/GPBMetadata/Google/Cloud/Workflows',
'metadata/',
merge=preserve_copyright_year,
)
executions_library = Path(f"../{php.STAGING_DIR}/Workflows/Executions/v1").resolve()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we got read of the for here?

Copy link
Contributor Author

@bshaffer bshaffer Jul 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we don't need it! We removed the beta version so now there's only one.


# copy all src including partial veneer classes
s.move(
executions_library / 'src',
'src/Executions',
merge=preserve_copyright_year,
)
# copy proto files to src also
s.move(
executions_library / 'proto/src/Google/Cloud/Workflows',
'src/',
merge=preserve_copyright_year,
excludes=[
executions_library / "**/*_*.php"
]
)
s.move(
executions_library / 'tests/Unit',
'tests/Unit/Executions',
merge=preserve_copyright_year,
)
# copy GPBMetadata file to metadata
s.move(executions_library / 'proto/src/GPBMetadata/Google/Cloud/Workflows',
'metadata/',
merge=preserve_copyright_year,
)

# remove class_alias code
s.replace(
Expand Down
2 changes: 1 addition & 1 deletion Workflows/samples/V1/WorkflowsClient/create_workflow.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php
/*
* Copyright 2023 Google LLC
* Copyright 2024 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down
2 changes: 1 addition & 1 deletion Workflows/samples/V1/WorkflowsClient/delete_workflow.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php
/*
* Copyright 2023 Google LLC
* Copyright 2024 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down
2 changes: 1 addition & 1 deletion Workflows/samples/V1/WorkflowsClient/get_location.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php
/*
* Copyright 2023 Google LLC
* Copyright 2024 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down
2 changes: 1 addition & 1 deletion Workflows/samples/V1/WorkflowsClient/get_workflow.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php
/*
* Copyright 2023 Google LLC
* Copyright 2024 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down
2 changes: 1 addition & 1 deletion Workflows/samples/V1/WorkflowsClient/list_locations.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php
/*
* Copyright 2023 Google LLC
* Copyright 2024 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down
2 changes: 1 addition & 1 deletion Workflows/samples/V1/WorkflowsClient/list_workflows.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php
/*
* Copyright 2023 Google LLC
* Copyright 2024 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down
2 changes: 1 addition & 1 deletion Workflows/samples/V1/WorkflowsClient/update_workflow.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php
/*
* Copyright 2023 Google LLC
* Copyright 2024 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down
93 changes: 0 additions & 93 deletions Workflows/samples/V1beta/WorkflowsClient/create_workflow.php
View file
Open in desktop

This file was deleted.

78 changes: 0 additions & 78 deletions Workflows/samples/V1beta/WorkflowsClient/delete_workflow.php
View file
Open in desktop

This file was deleted.

67 changes: 0 additions & 67 deletions Workflows/samples/V1beta/WorkflowsClient/get_workflow.php
View file
Open in desktop

This file was deleted.

Loading
Loading