Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: promote Workflows to stable and drop V1beta1 #7543

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

bshaffer
Copy link
Contributor

@bshaffer bshaffer commented Jul 23, 2024

BREAKING_CHANGE_REASON=Drop v1beta classes for promotion to GA

BEGIN_VERSION_OVERRIDE
Workflows: 1.0.0
END_VERSION_OVERRIDE

@bshaffer bshaffer marked this pull request as ready for review July 23, 2024 18:39
@bshaffer bshaffer requested review from a team as code owners July 23, 2024 18:39
Copy link

snippet-bot bot commented Jul 23, 2024

Here is the summary of changes.

You are about to delete 5 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@bshaffer bshaffer requested a review from Hectorhammett July 23, 2024 18:39
@bshaffer bshaffer added the next release PRs to be included in the next release label Jul 23, 2024
'metadata/',
merge=preserve_copyright_year,
)
executions_library = Path(f"../{php.STAGING_DIR}/Workflows/Executions/v1").resolve()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we got read of the for here?

Copy link
Contributor Author

@bshaffer bshaffer Jul 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we don't need it! We removed the beta version so now there's only one.

@bshaffer bshaffer merged commit f02dc1c into main Jul 24, 2024
29 of 32 checks passed
@bshaffer bshaffer deleted the drop-workflows-v1beta1 branch July 24, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next release PRs to be included in the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants