First Bigtable gapic gen for php #731

andreamlin · 2017-11-08T22:16:55Z

Copied over from api-client-staging

andreamlin · 2017-11-09T17:36:53Z

~~PTAL~~
running php style fixer..

michaelbausor · 2017-11-09T17:51:20Z

GAPIC code looks good, but there are some other changes that we will need in addition. Check out this PR, which adds the DLP API for the first time: #569

In particular, we will need:

Updates to settings files in docs folder
LICENSE file
README files
composer.json file
Version bump for proto-client library to a version that includes the newly merged Bigtable protobuf classes

…er.json

dwsupplee · 2017-11-09T18:15:39Z

@andreamlin, Did you run artman using PHP 5.5 by any chance? @vam-google discovered an issue where php-cs-fixer was failing silently during generation as it was requiring a version of PHP greater than 5.5.

googleapis/artman#310 &
googleapis/artman#316

should address that issue and will use a ruleset which fixes items like extra whitespace and unused imports.

andreamlin · 2017-11-09T18:17:19Z

@dwsupplee I'm running php v5.5.9. That should be fine, right?
I'm also using a later version of artman that contains those changes.

dwsupplee · 2017-11-09T18:27:06Z

Yeah, v5.5.9 should work!

Do you know which version of php-cs-fixer you are running? It should be v2.2.7 to ensure compatability with your version of PHP. The reason I ask is because it appears the task may have failed:

https://github.com/GoogleCloudPlatform/google-cloud-php/pull/731/files#diff-5235c551bb78376c8ebd0495ed33870aR55 (unused import, should be removed)

https://github.com/GoogleCloudPlatform/google-cloud-php/pull/731/files#diff-5235c551bb78376c8ebd0495ed33870aR222 (extra whitespace)

…-cs-fixer:2.2.7; ran phpcbf style fixer on result

andreamlin · 2017-11-09T21:02:01Z

I was using the wrong version of php-cs-fixer :/
Regen'd using php-cs-fixer 2.7
PTAL

dwsupplee · 2017-11-10T18:05:18Z

The autogen code LGTM now. Nice work!

We still will need the changes @michaelbausor mentioned earlier in the thread, as well as a VERSION file (it can just be versioned as master right now).

… into php_bigtable

andreamlin · 2017-11-15T20:28:06Z

Added VERSION, license, readme, bigtable/composer.json, and docs files; updated top-level composer.json.
PTAL

michaelbausor · 2017-11-17T16:53:42Z

LGTM, @dwsupplee and/or @jdpedrie can you also take a look?

dwsupplee

We need a readme (ex: https://github.com/GoogleCloudPlatform/google-cloud-php/blob/master/src/Dlp/V2beta1/README.md) in each directory that as a *ServiceClient. Outside of these last few nits, looks good to me.

docs/manifest.json

+        {
+            "id": "cloud-bigtable",
+            "name": "google/cloud-bigtable",
+            "defaultService": "bigtable/bigtableclient",


andreamlin · 2017-11-17T17:59:55Z

@dwsupplee Added a README.md to the bigtable/v2 directory.

docs/contents/cloud-bigtable.json

+    "pattern": "bigtable\/\\w{1,}",
+    "services": [{
+        "title": "BigtableClient",
+        "type": "bigtable/bigtableclient"


src/Bigtable/composer.json

+            "id": "cloud-bigtable",
+            "target": "GoogleCloudPlatform/google-cloud-php-bigtable.git",
+            "path": "src/Bigtable",
+            "entry": "BigtableClient.php"


dwsupplee

LGTM. Thanks @andreamlin

first bigtable gapic gen for php

ac4f403

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 8, 2017

adding bigtable admin

6253bb6

andreamlin requested a review from michaelbausor November 9, 2017 17:36

ran PHPCBF to format php files; added first draft of Bigtable/compos…

0fa5425

…er.json

copied over bigtable from api-client-staging after regening using php…

f61e2a2

…-cs-fixer:2.2.7; ran phpcbf style fixer on result

andreamlin and others added 17 commits November 15, 2017 11:00

adding docs/contents/cloud-bigtable.json

dd33390

spacing in composer.json

1ad4c0a

adding bigtable VERSION and in composer.json

cecb09e

updated manifest.json with bigtable and to master

8025d1c

adding readme for bigtable

8d9eef1

use master's version of non-bigtable things

059955b

update to master

9fd184e

update tests/ to master

5a25d63

update to master

3b9c49c

update to master

9998161

update to master

935615f

new line

3af9252

Merge branch 'master' into php_bigtable

ab909dc

Merge branch 'master' into php_bigtable

54690dd

bump version to master's proto-client (0.26)

9535fc7

removed extraneous comma in cloud-bigtable.json

c7c0c59

Merge branch 'php_bigtable' of github.com:andreamlin/google-cloud-php…

3f7250e

… into php_bigtable

dwsupplee approved these changes Nov 17, 2017

View reviewed changes

docs/manifest.json Outdated

{

"id": "cloud-bigtable",

"name": "google/cloud-bigtable",

"defaultService": "bigtable/bigtableclient",

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

manifest.json: bigtable/readme

6ff1c62

added readme

6a95a5a

dwsupplee reviewed Nov 17, 2017

View reviewed changes

docs/contents/cloud-bigtable.json Outdated

"pattern": "bigtable\/\\w{1,}",

"services": [{

"title": "BigtableClient",

"type": "bigtable/bigtableclient"

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

dwsupplee reviewed Nov 17, 2017

View reviewed changes

src/Bigtable/composer.json Outdated

"id": "cloud-bigtable",

"target": "GoogleCloudPlatform/google-cloud-php-bigtable.git",

"path": "src/Bigtable",

"entry": "BigtableClient.php"

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

updating json files

b9691ae

dwsupplee approved these changes Nov 17, 2017

View reviewed changes

dwsupplee merged commit 1820c01 into googleapis:master Nov 17, 2017

andreamlin deleted the php_bigtable branch November 17, 2017 21:41

jdpedrie mentioned this pull request Nov 20, 2017

Add support for Bigtable #283

Closed

jdpedrie added the api: bigtable Issues related to the Bigtable API. label Dec 22, 2017

jdpedrie mentioned this pull request Dec 22, 2017

Prepare v0.48.0 #814

Merged

googleapis deleted a comment from andreamlin Dec 14, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

First Bigtable gapic gen for php #731

First Bigtable gapic gen for php #731

andreamlin commented Nov 8, 2017

andreamlin commented Nov 9, 2017 •

edited

Loading

michaelbausor commented Nov 9, 2017

dwsupplee commented Nov 9, 2017

andreamlin commented Nov 9, 2017 •

edited

Loading

dwsupplee commented Nov 9, 2017 •

edited

Loading

andreamlin commented Nov 9, 2017

dwsupplee commented Nov 10, 2017

andreamlin commented Nov 15, 2017

michaelbausor commented Nov 17, 2017

dwsupplee left a comment

This comment was marked as spam.

This comment was marked as spam.

andreamlin commented Nov 17, 2017

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

dwsupplee left a comment

First Bigtable gapic gen for php #731

First Bigtable gapic gen for php #731

Conversation

andreamlin commented Nov 8, 2017

andreamlin commented Nov 9, 2017 • edited Loading

michaelbausor commented Nov 9, 2017

dwsupplee commented Nov 9, 2017

andreamlin commented Nov 9, 2017 • edited Loading

dwsupplee commented Nov 9, 2017 • edited Loading

andreamlin commented Nov 9, 2017

dwsupplee commented Nov 10, 2017

andreamlin commented Nov 15, 2017

michaelbausor commented Nov 17, 2017

dwsupplee left a comment

Choose a reason for hiding this comment

This comment was marked as spam.

This comment was marked as spam.

andreamlin commented Nov 17, 2017

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

dwsupplee left a comment

Choose a reason for hiding this comment

andreamlin commented Nov 9, 2017 •

edited

Loading

andreamlin commented Nov 9, 2017 •

edited

Loading

dwsupplee commented Nov 9, 2017 •

edited

Loading