Add DLP API #569
Merged
Add DLP API #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
We will want to bump the main composer file as well as each of the ones found in the GAPIC APIs for best compatibility. |
|
Updated gax and proto-client versions |
dwsupplee
reviewed
Jul 11, 2017
| * tracking the number of files written. <p>The CSV file(s) contain the | ||
| * following columns regardless of storage type scanned: <li>id <li>info_type | ||
| * <li>likelihood <li>byte size of finding <li>quote <li>time_stamp<br/> | ||
| * <p>For Cloud Storage the next columns are: <li>file_path |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
src/Dlp/V2beta1/DlpServiceClient.php
Outdated
| * | ||
| * @param string $name Identifier of the results set returned as metadata of | ||
| * the longrunning operation created by a call to CreateInspectOperation. | ||
| * Should be in the format of `inspect/results/{id}. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
dwsupplee
approved these changes
Jul 11, 2017
|
Shall we merge and get a release tagged, or would you prefer to wait on googleapis/gapic-generator#1409? |
|
I think merging and tagging, if you are comfortable with that. While it would be nice to fix the |
|
Sounds good |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @neozwu
This PR requires a new version of proto-client (0.21), which is not yet released. I wanted to check where I should bump up the version of proto-client in composer.json files in order ensure compatibility: