Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [Run] Removes accidentally exposed field service.traffic_tags_cleanup_threshold in Cloud Run Service #6665

Merged
merged 2 commits into from
Sep 28, 2023
Merged

fix: [Run] Removes accidentally exposed field service.traffic_tags_cleanup_threshold in Cloud Run Service #6665

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1df4db2
fix: Removes accidentally exposed field service.traffic_tags_cleanup_…
gcf-owl-bot[bot] Sep 28, 2023
926d1a8
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions Run/metadata/V2/Service.php
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 8 additions & 8 deletions Run/src/V2/EnvVar.php
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Run/src/V2/RunJobRequest/Overrides.php
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Run/src/V2/RunJobRequest/Overrides/ContainerOverride.php
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

42 changes: 0 additions & 42 deletions Run/src/V2/Service.php
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 0 additions & 10 deletions Run/tests/Unit/V2/Client/ServicesClientTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,6 @@ public function createServiceTest()
$latestCreatedRevision = 'latestCreatedRevision452370698';
$uri = 'uri116076';
$satisfiesPzs = false;
$trafficTagsCleanupThreshold = 795495828;
$reconciling = false;
$etag = 'etag3123477';
$expectedResponse = new Service();
Expand All @@ -126,7 +125,6 @@ public function createServiceTest()
$expectedResponse->setLatestCreatedRevision($latestCreatedRevision);
$expectedResponse->setUri($uri);
$expectedResponse->setSatisfiesPzs($satisfiesPzs);
$expectedResponse->setTrafficTagsCleanupThreshold($trafficTagsCleanupThreshold);
$expectedResponse->setReconciling($reconciling);
$expectedResponse->setEtag($etag);
$anyResponse = new Any();
Expand Down Expand Up @@ -278,7 +276,6 @@ public function deleteServiceTest()
$latestCreatedRevision = 'latestCreatedRevision452370698';
$uri = 'uri116076';
$satisfiesPzs = false;
$trafficTagsCleanupThreshold = 795495828;
$reconciling = false;
$etag2 = 'etag2-1293302904';
$expectedResponse = new Service();
Expand All @@ -295,7 +292,6 @@ public function deleteServiceTest()
$expectedResponse->setLatestCreatedRevision($latestCreatedRevision);
$expectedResponse->setUri($uri);
$expectedResponse->setSatisfiesPzs($satisfiesPzs);
$expectedResponse->setTrafficTagsCleanupThreshold($trafficTagsCleanupThreshold);
$expectedResponse->setReconciling($reconciling);
$expectedResponse->setEtag($etag2);
$anyResponse = new Any();
Expand Down Expand Up @@ -485,7 +481,6 @@ public function getServiceTest()
$latestCreatedRevision = 'latestCreatedRevision452370698';
$uri = 'uri116076';
$satisfiesPzs = false;
$trafficTagsCleanupThreshold = 795495828;
$reconciling = false;
$etag = 'etag3123477';
$expectedResponse = new Service();
Expand All @@ -502,7 +497,6 @@ public function getServiceTest()
$expectedResponse->setLatestCreatedRevision($latestCreatedRevision);
$expectedResponse->setUri($uri);
$expectedResponse->setSatisfiesPzs($satisfiesPzs);
$expectedResponse->setTrafficTagsCleanupThreshold($trafficTagsCleanupThreshold);
$expectedResponse->setReconciling($reconciling);
$expectedResponse->setEtag($etag);
$transport->addResponse($expectedResponse);
Expand Down Expand Up @@ -803,7 +797,6 @@ public function updateServiceTest()
$latestCreatedRevision = 'latestCreatedRevision452370698';
$uri = 'uri116076';
$satisfiesPzs = false;
$trafficTagsCleanupThreshold = 795495828;
$reconciling = false;
$etag = 'etag3123477';
$expectedResponse = new Service();
Expand All @@ -820,7 +813,6 @@ public function updateServiceTest()
$expectedResponse->setLatestCreatedRevision($latestCreatedRevision);
$expectedResponse->setUri($uri);
$expectedResponse->setSatisfiesPzs($satisfiesPzs);
$expectedResponse->setTrafficTagsCleanupThreshold($trafficTagsCleanupThreshold);
$expectedResponse->setReconciling($reconciling);
$expectedResponse->setEtag($etag);
$anyResponse = new Any();
Expand Down Expand Up @@ -960,7 +952,6 @@ public function createServiceAsyncTest()
$latestCreatedRevision = 'latestCreatedRevision452370698';
$uri = 'uri116076';
$satisfiesPzs = false;
$trafficTagsCleanupThreshold = 795495828;
$reconciling = false;
$etag = 'etag3123477';
$expectedResponse = new Service();
Expand All @@ -977,7 +968,6 @@ public function createServiceAsyncTest()
$expectedResponse->setLatestCreatedRevision($latestCreatedRevision);
$expectedResponse->setUri($uri);
$expectedResponse->setSatisfiesPzs($satisfiesPzs);
$expectedResponse->setTrafficTagsCleanupThreshold($trafficTagsCleanupThreshold);
$expectedResponse->setReconciling($reconciling);
$expectedResponse->setEtag($etag);
$anyResponse = new Any();
Expand Down
8 changes: 0 additions & 8 deletions Run/tests/Unit/V2/ServicesClientTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@ public function createServiceTest()
$latestCreatedRevision = 'latestCreatedRevision452370698';
$uri = 'uri116076';
$satisfiesPzs = false;
$trafficTagsCleanupThreshold = 795495828;
$reconciling = false;
$etag = 'etag3123477';
$expectedResponse = new Service();
Expand All @@ -118,7 +117,6 @@ public function createServiceTest()
$expectedResponse->setLatestCreatedRevision($latestCreatedRevision);
$expectedResponse->setUri($uri);
$expectedResponse->setSatisfiesPzs($satisfiesPzs);
$expectedResponse->setTrafficTagsCleanupThreshold($trafficTagsCleanupThreshold);
$expectedResponse->setReconciling($reconciling);
$expectedResponse->setEtag($etag);
$anyResponse = new Any();
Expand Down Expand Up @@ -262,7 +260,6 @@ public function deleteServiceTest()
$latestCreatedRevision = 'latestCreatedRevision452370698';
$uri = 'uri116076';
$satisfiesPzs = false;
$trafficTagsCleanupThreshold = 795495828;
$reconciling = false;
$etag2 = 'etag2-1293302904';
$expectedResponse = new Service();
Expand All @@ -279,7 +276,6 @@ public function deleteServiceTest()
$expectedResponse->setLatestCreatedRevision($latestCreatedRevision);
$expectedResponse->setUri($uri);
$expectedResponse->setSatisfiesPzs($satisfiesPzs);
$expectedResponse->setTrafficTagsCleanupThreshold($trafficTagsCleanupThreshold);
$expectedResponse->setReconciling($reconciling);
$expectedResponse->setEtag($etag2);
$anyResponse = new Any();
Expand Down Expand Up @@ -461,7 +457,6 @@ public function getServiceTest()
$latestCreatedRevision = 'latestCreatedRevision452370698';
$uri = 'uri116076';
$satisfiesPzs = false;
$trafficTagsCleanupThreshold = 795495828;
$reconciling = false;
$etag = 'etag3123477';
$expectedResponse = new Service();
Expand All @@ -478,7 +473,6 @@ public function getServiceTest()
$expectedResponse->setLatestCreatedRevision($latestCreatedRevision);
$expectedResponse->setUri($uri);
$expectedResponse->setSatisfiesPzs($satisfiesPzs);
$expectedResponse->setTrafficTagsCleanupThreshold($trafficTagsCleanupThreshold);
$expectedResponse->setReconciling($reconciling);
$expectedResponse->setEtag($etag);
$transport->addResponse($expectedResponse);
Expand Down Expand Up @@ -759,7 +753,6 @@ public function updateServiceTest()
$latestCreatedRevision = 'latestCreatedRevision452370698';
$uri = 'uri116076';
$satisfiesPzs = false;
$trafficTagsCleanupThreshold = 795495828;
$reconciling = false;
$etag = 'etag3123477';
$expectedResponse = new Service();
Expand All @@ -776,7 +769,6 @@ public function updateServiceTest()
$expectedResponse->setLatestCreatedRevision($latestCreatedRevision);
$expectedResponse->setUri($uri);
$expectedResponse->setSatisfiesPzs($satisfiesPzs);
$expectedResponse->setTrafficTagsCleanupThreshold($trafficTagsCleanupThreshold);
$expectedResponse->setReconciling($reconciling);
$expectedResponse->setEtag($etag);
$anyResponse = new Any();
Expand Down
Loading