Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [Run] Removes accidentally exposed field service.traffic_tags_cleanup_threshold in Cloud Run Service #6665

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Sep 28, 2023

  • Regenerate this pull request now.

docs: Minor comment fixes

PiperOrigin-RevId: 568981386

Source-Link: googleapis/googleapis@01711ae

Source-Link: https://github.com/googleapis/googleapis-gen/commit/cc2e659f8cf5a458d6f7a2c0f8f7cfa54ef5402c
Copy-Tag: eyJwIjoiUnVuLy5Pd2xCb3QueWFtbCIsImgiOiJjYzJlNjU5ZjhjZjVhNDU4ZDZmN2EyYzBmOGY3Y2ZhNTRlZjU0MDJjIn0=

BREAKING_CHANGE_REASON=the removed methods have not been released yet, so rolling them back now is not a breaking change.

…threshold in Cloud Run Service

docs: Minor comment fixes

PiperOrigin-RevId: 568981386

Source-Link: googleapis/googleapis@01711ae

Source-Link: googleapis/googleapis-gen@cc2e659
Copy-Tag: eyJwIjoiUnVuLy5Pd2xCb3QueWFtbCIsImgiOiJjYzJlNjU5ZjhjZjVhNDU4ZDZmN2EyYzBmOGY3Y2ZhNTRlZjU0MDJjIn0=
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 28, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 28, 2023
@gcf-owl-bot gcf-owl-bot bot marked this pull request as ready for review September 28, 2023 00:58
@gcf-owl-bot gcf-owl-bot bot requested review from a team as code owners September 28, 2023 00:58
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 28, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 28, 2023
@bshaffer bshaffer added the release blocking Required feature/issue must be fixed prior to next release. label Sep 28, 2023
@bshaffer
Copy link
Contributor

bshaffer commented Sep 28, 2023

The two removed methods (Google\Cloud\Run\V2\Service#getTrafficTagsCleanupThreshold() and Google\Cloud\Run\V2\Service#setTrafficTagsCleanupThreshold()) were added in #6653 (see here), which hasn't been released yet. So this is not actually a breaking change.

@bshaffer bshaffer enabled auto-merge (squash) September 28, 2023 02:07
@bshaffer bshaffer merged commit a42e6c0 into main Sep 28, 2023
25 of 26 checks passed
@bshaffer bshaffer deleted the owl-bot-copy-Run branch September 28, 2023 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
owl-bot-copy release blocking Required feature/issue must be fixed prior to next release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant