-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Firestore): SUM / AVG aggregation feature #6557
Conversation
Update aggregation type tests Update aggregation query test Updated AggregationQueryTests Update transaction unit tests Temp commit Many Changes * Added multi value type return support for aggregation queries * Ammended Unit tests to conver this ammendment Add check for multi type result * Ammend to `getSnapshot` test so as to make sure the tests pass only if the logic allows any of the type to be returned. Modify existing aggregation tests to accomodate sum and avergate feature testing. update trasaction aggregation tests
16de7d7
to
26df558
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall changes and tests looks good to me.. Left a few nits.
Once those are closed, we can merge this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some nits
…into firestore-sum-avg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed that the changes work locally. Lgtm
Enables sum and average aggregation query.
Design doc: go/php-firestore-sum-avg