chore(Firestore): Refactor Aggregation System Tests #6717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: firestore
yash30201
force-pushed
the
fs-refactor-aggregation-sys-test
branch
from
233da1c to
d0ed292
Compare
vishwarajanand
approved these changes
Oct 18, 2023
There was a problem hiding this comment.
Approving to unblock.
- I raised chore: fix bootstrap file path for system and perf tests #6726 for fixing the bootstrap filepaths during test runs.
- Pls take care of bumping up the core version in Firestore library.
yash30201
added a commit
to yash30201/google-cloud-php
that referenced
this pull request
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor all the system tests written for
countaggregation so that they use a data provider pattern and are extensible to new upcoming aggregations like sum / average / min / max queries.