feat(Spanner): enable drop db protection

[vishwarajanand]

Note: This can only be merged when the gapic changes are added. Sample gapic changes can be viewed here: #6009. Till owlbot PR is merge, tests will fail.

Enables drop db feature in Spanner.
Design doc: go/drop-db-protection-spanner-php

Changes

1. Adds a update Database functionality
2. Added UT and integration test for the same

Tests

1. Integration tests pass on PROD:

➜  Spanner git:(drop-database-protection-changes) ✗ echo $SPANNER_EMULATOR_HOST

➜  Spanner git:(drop-database-protection-changes) ✗ vendor/bin/phpunit -c phpunit-system.xml.dist --filter="testDatabaseDropProtection"
PHPUnit 8.5.33 by Sebastian Bergmann and contributors.

.                                                                   1 / 1 (100%)

Time: 2.85 minutes, Memory: 12.00 MB

OK (1 test, 9 assertions)
➜  Spanner git:(drop-database-protection) ✗

2. Other tests (UT and Snippet tests pass)

3. Test script returns expected results:

Code to evaluate Database::updateDatabase(..)

require_once __DIR__ . '/vendor/autoload.php';

// get a db

use Google\Cloud\Core\Exception\FailedPreconditionException;
use Google\Cloud\Spanner\SpannerClient;

$INSTANCE_NAME = 'google-cloud-php-system-tests';
// $dbName = 'gcloud_testing_640a1bb0a4fef';

$keyFilePath = getenv('GOOGLE_CLOUD_PHP_TESTS_KEY_PATH');

$clientConfig = [
  'keyFilePath' => $keyFilePath
];
$client = new SpannerClient($clientConfig);
$instance = $client->instance($INSTANCE_NAME);

// create a db with drop protection
$dbName = uniqid('gcloud_testing');
$op = $instance->createDatabase($dbName, ['enableDropProtection' => true]);
$op->pollUntilComplete();

$database = $instance->database($dbName);

// get value for enableDropProtection
$info = $database->reload();
echo 'enableDropProtection is ' . (string)(int)$info['enableDropProtection'] . ' expecting true' . PHP_EOL;

// update drop protection (enable)
$op = $database->updateDatabase(['enableDropProtection' => true]);
$op->pollUntilComplete();

$info = $database->reload();
echo 'enableDropProtection is ' . (string)(int)$info['enableDropProtection'] . ' expecting true' . PHP_EOL;

// delete should fail
$isException = false;
try{
    $database->drop();
} catch (FailedPreconditionException $ex){
    $isException = true;
    echo "Exception raised while dropping DB as expected.".PHP_EOL;
}
if (!$isException) {
  echo "NO Exception raised while dropping DB, expected an exception.".PHP_EOL;
}
echo 'Database exists check returns ' . (string)(int)$database->exists() . ' expecting true' . PHP_EOL;

// update drop protection (disable)
$op = $database->updateDatabase(['enableDropProtection' => false]);
$op->pollUntilComplete();

$info = $database->reload();
echo 'enableDropProtection is ' . (string)(int)$info['enableDropProtection'] . ' expecting false' . PHP_EOL;

// delete should pass
$database->drop();
echo 'Database exists check returns ' . (string)(int)$database->exists() . ' expecting false' . PHP_EOL;

echo "Test script completed successfully, compare printed vs expected values." . PHP_EOL;

BREAKING_CHANGE_REASON="New api added"

[vishwarajanand]

By mistake, I pushed the gapic changes too. I will fix it when its time to merge this PR.

[vishwarajanand]

I added a BREAKING_CHANGE_REASON still the breaking changes check is failing.

[bshaffer]

That’s because you also need the “breaking change allowed” label

On Sat, Jun 17, 2023 at 5:40 AM Vishwaraj Anand ***@***.***> wrote: I added a BREAKING_CHANGE_REASON still the breaking changes check is failing. — Reply to this email directly, view it on GitHub <#6008 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAZMBJTUN67MBINFN2S6A3XLWJTPANCNFSM6AAAAAAWKUOBDE> . You are receiving this because your review was requested.Message ID: ***@***.***>

-- Brent Shaffer

[yash30201]

LGTM