Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Spanner): add sample for update database #1793

Merged
merged 7 commits into from
Jun 21, 2023

Conversation

vishwarajanand
Copy link
Member

@vishwarajanand vishwarajanand commented Mar 30, 2023

Adding samples for update database RPC, providing enable drop protection for databases.

Note: tests will fail unless feature PR is merged & released: googleapis/google-cloud-php#6008

@vishwarajanand vishwarajanand added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 30, 2023
@vishwarajanand vishwarajanand requested review from a team as code owners March 30, 2023 05:37
@snippet-bot
Copy link

snippet-bot bot commented Mar 30, 2023

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added api: spanner Issues related to the Spanner API. samples Issues that are directly related to samples. labels Mar 30, 2023
spanner/composer.json Outdated Show resolved Hide resolved
@bshaffer bshaffer removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 21, 2023
@bshaffer
Copy link
Contributor

Still getting the following error:

There was 1 error:

1) Google\Cloud\Samples\Spanner\spannerTest::testUpdateDatabase
Error: Cannot use object of type Google\ApiCore\OperationResponse as array

/tmpfs/src/github/php-docs-samples/spanner/src/update_database.php:52
/tmpfs/src/github/php-docs-samples/testing/sample_helpers.php:59
/tmpfs/src/github/php-docs-samples/spanner/src/update_database.php:59
/tmpfs/src/github/php-docs-samples/testing/vendor/google/cloud-tools/src/TestUtils/TestTrait.php:134
/tmpfs/src/github/php-docs-samples/testing/vendor/google/cloud-tools/src/TestUtils/TestTrait.php:146
/tmpfs/src/github/php-docs-samples/testing/vendor/google/cloud-tools/src/TestUtils/TestTrait.php:104
/tmpfs/src/github/php-docs-samples/spanner/test/spannerTest.php:1123
/tmpfs/src/github/php-docs-samples/spanner/test/spannerTest.php:247
/tmpfs/src/github/php-docs-samples/testing/vendor/bshaffer/phpunit-retry-annotations/src/RetryTrait.php:33

@vishwarajanand
Copy link
Member Author

@bshaffer fixed the tests

spanner/composer.json Outdated Show resolved Hide resolved
@vishwarajanand vishwarajanand merged commit 0d8f29d into main Jun 21, 2023
@vishwarajanand vishwarajanand deleted the drop-database-protection branch June 21, 2023 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Spanner API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants