Partial veneer GAPIC refresh

[michaelbausor]

cc @garrettjonesgoogle @lukesneeringer @shinfan

Toolkit PR: googleapis/gapic-generator#1428

This PR shows the expected changes from implementing partial veneers in PHP. It only updates the Vision API, and does not yet include the manual methods that will be added.

[jdpedrie]

sorry for the noise. didn't mean to click approve on this. -_-

[michaelbausor]

@dwsupplee @jdpedrie I would like to move forward with this PR. I realize it is kind of a nightmare to review, because so many things change. The manual changes that definitely need review are changes in src/Spanner/Connection/Grpc.php that are necessary after the update to GAX and protobuf 3.4, and changes in tests/unit/Core/GrpcRequestWrapperTest.php, which are necessary to allow unit tests to run using the protobuf c extension, because c classes seem incompatible with prophecy.

When it comes to the rest of the PR, I am not sure what approach to take - I am happy to try to make changes to help with review.

Also note that this PR will fail tests until GAX 0.22.1 is released (pending this PR: googleapis/gax-php#94)

[michaelbausor]

Also, if possible it would be great to get another pair of eyes on googleapis/gax-php#94 if you have a chance

[dwsupplee]

I didn't spend much time on the generated clients as it looks like the only change was the inherit tag and the extension. Please let me know if otherwise.

Everything else looks good to me, with one thing I am curious about - If I were a new user coming in to this ecosystem why do I choose DlpServiceClient over DlpServiceGapicClient?

To help answer that, what do you think about moving the *-GapicClients to their own directory - or is there a clear use case for having them both be exposed at the same level?

[michaelbausor]

I don't think there is a clear use case - I would expect users to never interact with the GapicClient objects. I am happy to move the gapic client into its own folder. My first thought is:

- Dlp
  - V2beta1
    - DlpServiceClient.php
    - Gapic
      - DlpServiceGapicClient.php

but I could also see this working:

- Dlp
  - V2beta1
    - DlpServiceClient.php
  - Gapic
    - V2beta1
      - DlpServiceGapicClient.php

Which do you think is better?

[dwsupplee]

My vote goes for option 1 :)