Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DEFAULT keyword in generated protobuf class #94

Merged
merged 2 commits into from
Aug 17, 2017

Conversation

michaelbausor
Copy link
Contributor

  • Add a test that instantiates all of the generated protobuf classes in src/generated
  • Rename instance of invalid DEFAULT keyword

@garrettjonesgoogle
Copy link
Member

PHP, you are weird.

This looks reasonable to me, but since I don't have much familiarity with the things you are calling, let someone else look too.

@codecov-io
Copy link

codecov-io commented Aug 16, 2017

Codecov Report

Merging #94 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #94   +/-   ##
=======================================
  Coverage   90.52%   90.52%           
=======================================
  Files          33       33           
  Lines        2249     2249           
=======================================
  Hits         2036     2036           
  Misses        213      213

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6d8ed2...fc22d47. Read the comment docs.

@michaelbausor
Copy link
Contributor Author

@shinfan @neozwu Can either of you take a look? If possible I would like to merge this today. Thanks!

Copy link
Contributor

@shinfan shinfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelbausor michaelbausor merged commit 79d526f into googleapis:master Aug 17, 2017
@michaelbausor michaelbausor deleted the fix-keyword branch August 17, 2017 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants