Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not filter falsey values #318

Merged
merged 2 commits into from
Jan 18, 2017
Merged

Do not filter falsey values #318

merged 2 commits into from
Jan 18, 2017

Conversation

dwsupplee
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 17, 2017
@dwsupplee dwsupplee mentioned this pull request Jan 17, 2017
Closed
@jdpedrie
Copy link
Contributor

@dwsupplee, please take a look at the email I just sent you. :)

waynerasmussck
waynerasmussck reviewed Jan 18, 2017
View reviewed changes
Copy link

@waynerasmussck waynerasmussck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comments should also be clarified. The comments should be moved down after the array_filter line on 52 as they don't have anything to do with that, but talk about the lines 55 through 57

@dwsupplee
Copy link
Contributor Author

Good call @waynerasmussck. Updated!

@dwsupplee dwsupplee merged commit 985f916 into googleapis:master Jan 18, 2017
@jdpedrie jdpedrie mentioned this pull request Feb 10, 2017
Merged
jdpedrie pushed a commit that referenced this pull request Feb 15, 2017
@dwsupplee @jdpedrie
Do not filter falsey values (#318)
6788b6d 
* do not filter falsey values

* move comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynerasmussck waynerasmussck waynerasmussck left review comments

@jdpedrie jdpedrie jdpedrie approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dwsupplee @jdpedrie @waynerasmussck @googlebot