Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options with falesy values are stripped from $storageClient->bucket->objects call #317

Closed
waynerasmussck opened this issue Jan 17, 2017 · 3 comments
Assignees
Labels
🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@waynerasmussck
Copy link

The problem exhibits itself with the following call:

$generator = $this->storageClient->bucket('some-bucket-identifier)->objects(['prefix' => '0']);

This is caused by this code

Google\Cloud\UriTrait line 52

      $query = array_filter($query);

For example I wanted to find files beginning with "0" (the string zero) but this gets filtered out because the string "0" is treated as false.

@dwsupplee
Copy link
Contributor

dwsupplee commented Jan 17, 2017

Nice work finding this, and sorry for any headaches it may have caused! When you have a moment could you please check out #318 and let me know if it resolves the issue for you?

@waynerasmussck
Copy link
Author

Those changes look like they will fix this problem.

@dwsupplee
Copy link
Contributor

Closed by #318

@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Development

No branches or pull requests

3 participants