Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uses resourceNames instead of projectId for Logging API entities.list #235

Merged
merged 4 commits into from
Nov 22, 2016
Merged

uses resourceNames instead of projectId for Logging API entities.list #235

merged 4 commits into from
Nov 22, 2016

Conversation

bshaffer
Copy link
Contributor

@bshaffer bshaffer commented Nov 8, 2016

see #211

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 8, 2016
Copy link
Contributor

@jdpedrie jdpedrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but @dwsupplee is the logging guy so I'd prefer to wait for his sign off too.

@dwsupplee
Copy link
Contributor

OOO this week with limited email access. I'll have a chance to review tomorrow.

@dwsupplee
Copy link
Contributor

Thanks @bshaffer, few things I noted:

  1. We should add resourceNames to the docblock of the entries method.

  2. We will need to update this line to use resourceNames.

  3. It looks like the generated code may need to be updated. @michaelbausor when you have a moment would you be able to take a look?

@dwsupplee dwsupplee added the api: logging Issues related to the Cloud Logging API. label Nov 9, 2016
@michaelbausor
Copy link
Contributor

Yes, it looks like we should regenerate. Right now in our generated surface, projectIds is a required parameter. In the new surface, would we prefer:

  • resourceNames to be a required parameter, and projectIds to be optional (resourceNames can be set to an empty list if someone want to use only projectIds)
  • OR both resourceNames and projectIds to be optional parameters. In this case the method would have no required parameters.

@bshaffer
Copy link
Contributor Author

@michaelbausor I think it best to be consistent with the API, and make resourceNames the required parameter.

@michaelbausor
Copy link
Contributor

@bshaffer
Copy link
Contributor Author

@dwsupplee @jdpedrie this is ready for another look!

Copy link
Contributor

@dwsupplee dwsupplee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@dwsupplee dwsupplee merged commit 2299f1e into googleapis:master Nov 22, 2016
@bshaffer bshaffer deleted the issue-211 branch November 23, 2016 01:32
@jdpedrie jdpedrie mentioned this pull request Nov 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants