-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uses resourceNames instead of projectId for Logging API entities.list #235
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but @dwsupplee is the logging guy so I'd prefer to wait for his sign off too.
OOO this week with limited email access. I'll have a chance to review tomorrow. |
Thanks @bshaffer, few things I noted:
|
Yes, it looks like we should regenerate. Right now in our generated surface, projectIds is a required parameter. In the new surface, would we prefer:
|
@michaelbausor I think it best to be consistent with the API, and make |
@dwsupplee @jdpedrie this is ready for another look! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
see #211