Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use resourceNames instead of projectId for logging.entities.list #211

Closed
bshaffer opened this issue Oct 18, 2016 · 2 comments
Closed

use resourceNames instead of projectId for logging.entities.list #211

bshaffer opened this issue Oct 18, 2016 · 2 comments
Assignees
Labels
api: logging Issues related to the Cloud Logging API. 🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@bshaffer
Copy link
Contributor

the projectIds field is being deprecated for entities.list in favor of resourceNames.

The projectIds field will eventually be removed, so we should update the LoggingClient to prepare for this change:

        $resourceNames = ['projects/' . $this->projectId];
        if (isset($options['projectIds'])) {
            foreach ($options['projectIds'] as $projectId) {
                  $resourceNames[] = 'projects/' . $projectId;
            }
        }
        if (isset($options['resourceNames'])) {
            $options['resourceNames'] = array_merge($resourceNames, $options['projectIds']);
        } else {
            $options['resourceNames'] = $resourceNames;
        }
@dwsupplee dwsupplee added the api: logging Issues related to the Cloud Logging API. label Oct 19, 2016
@dwsupplee
Copy link
Contributor

Thanks for the heads up @bshaffer

@dwsupplee
Copy link
Contributor

Closed by #235

@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the Cloud Logging API. 🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Development

No branches or pull requests

3 participants