fix: Fix fluent setter in ExtractJobConfiguration #2328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
dwsupplee
suggested changes
Sep 16, 2019
| @@ -74,14 +74,15 @@ public function testFluentSetters() | |||
| ]; | |||
| $this->expectedConfig['configuration']['extract'] = $extract | |||
| + $this->expectedConfig['configuration']['extract']; | |||
| $this->config | |||
|
|
|||
| $this->assertInstanceOf(ExtractJobConfiguration::class, $this->config | |||
There was a problem hiding this comment.
Would we be able to make this assertion separate from the usage of the setters please?
Codecov Report
@@ Coverage Diff @@
## master #2328 +/- ##
=========================================
Coverage ? 92.49%
Complexity ? 4479
=========================================
Files ? 311
Lines ? 13358
Branches ? 0
=========================================
Hits ? 12355
Misses ? 1003
Partials ? 0
Continue to review full report at Codecov.
|
dwsupplee
approved these changes
Sep 16, 2019
This was referenced Jan 16, 2020
Closed
This was referenced Jan 30, 2020
Merged
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Counterpart to #2327 and an extra assertion in the job configuration tests to make sure the last setter (the most likely to be newly added) returns as expected.