Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect return value in LoadJobConfiguration #2327

Merged
merged 1 commit into from
Sep 16, 2019
Merged

Fix incorrect return value in LoadJobConfiguration #2327

merged 1 commit into from
Sep 16, 2019

Conversation

Firehed
Copy link
Contributor

@Firehed Firehed commented Sep 16, 2019

This corrects a minor issue in the BigQuery LoadJobConfiguration where useAvroLogicalTypes isn't adhering to the documented return type.

@Firehed Firehed requested a review from dwsupplee as a code owner September 16, 2019 18:54
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 16, 2019
dwsupplee
dwsupplee approved these changes Sep 16, 2019
View reviewed changes
Copy link
Contributor

@dwsupplee dwsupplee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much appreciated, thank you @Firehed!

@dwsupplee dwsupplee merged commit 3453a5a into googleapis:master Sep 16, 2019
@jdpedrie jdpedrie mentioned this pull request Sep 16, 2019
Merged
@dwsupplee
Copy link
Contributor

@Firehed, release can be found here: https://github.com/googleapis/google-cloud-php/releases/tag/v0.112.0. Thanks again for the PR.

@Firehed
Copy link
Contributor Author

Firehed commented Sep 16, 2019

That was fast! Thanks for the quick review :)

@Firehed Firehed deleted the patch-1 branch September 16, 2019 21:34
This was referenced Jan 16, 2020
Closed
Closed
Closed
Closed
This was referenced Jan 30, 2020
Merged
Closed
Closed
Closed
Closed
Merged
Merged
@yoshi-automation yoshi-automation mentioned this pull request Feb 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwsupplee dwsupplee dwsupplee approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Firehed @dwsupplee @googlebot