Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move common-protos to the monorepo #7554

Merged
merged 9 commits into from
Jul 31, 2024
Merged

feat: move common-protos to the monorepo #7554

merged 9 commits into from
Jul 31, 2024

Conversation

bshaffer
Copy link
Contributor

@bshaffer bshaffer commented Jul 25, 2024

Move the package google/common-protos (https://github.com/googleapis/common-protos-php) over to the monorepo.
Renames the existing CommonProtos repo to CloudCommonProtos, and uses CommonProtos as the directory for the common protos for all APIs.

This has the following advantages:

  1. Keeps things consistent with our other packages
  2. Keeps everything in one place, so we don't forget about it
  3. Keeps things consistent with our other packages
  4. Will deploy documentation to cloud.google.com/php/docs/reference/
  5. keeps things consistent with our other packages

NOTE: I have configured this to use the same repo (googleapis/common-protos-php), but the first push will require a --force, and will erase the history. I've tested this in composer, and upgrading to the new version / downgrading to the old one was not affected by rewriting the history, so this should not affect our users.

NOTE: This is definitely more of a chore than a feat, but I'd like to increment the version number to 0.5

@bshaffer bshaffer requested review from a team as code owners July 25, 2024 21:41
@bshaffer bshaffer requested a review from Hectorhammett July 30, 2024 03:17
@bshaffer bshaffer added the next release PRs to be included in the next release label Jul 30, 2024
@bshaffer bshaffer merged commit 3339a27 into main Jul 31, 2024
30 checks passed
@bshaffer bshaffer deleted the move-common-protos branch July 31, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next release PRs to be included in the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants