Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [Build] updates from OwlBrent #5934

Merged
merged 2 commits into from
Mar 9, 2023
Merged

feat: [Build] updates from OwlBrent #5934

merged 2 commits into from
Mar 9, 2023

Conversation

bshaffer
Copy link
Contributor

@bshaffer bshaffer commented Mar 7, 2023 •
edited
Loading

PiperOrigin-RevId: 513138925
Source-Link: googleapis/googleapis@187d780

@bshaffer bshaffer force-pushed the cloudbuild-v1-update branch 2 times, most recently from 68cf3ae to fc6748d Compare March 7, 2023 17:41
@bshaffer bshaffer marked this pull request as ready for review March 7, 2023 22:47
@bshaffer bshaffer requested review from a team as code owners March 7, 2023 22:47
@snippet-bot
Copy link

snippet-bot bot commented Mar 7, 2023 •
edited
Loading

Here is the summary of changes.

You are about to add 18 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@bshaffer bshaffer mentioned this pull request Mar 8, 2023
Merged
1 task
@bshaffer bshaffer added the next release PRs to be included in the next release label Mar 8, 2023
@bshaffer
Copy link
Contributor Author

bshaffer commented Mar 9, 2023

Here are the breaking changes. Namely, the WorkerPool message class changed, as did its CRUD methods:

Error: The number of required arguments for Google\Cloud\Build\V1\Gapic\CloudBuildGapicClient#createWorkerPool() increased from 0 to 3
Error: The parameter $optionalArgs of Google\Cloud\Build\V1\Gapic\CloudBuildGapicClient#createWorkerPool() changed from array to no type
Error: Parameter 0 of Google\Cloud\Build\V1\Gapic\CloudBuildGapicClient#createWorkerPool() changed name from optionalArgs to parent
Error: The number of required arguments for Google\Cloud\Build\V1\Gapic\CloudBuildGapicClient#deleteWorkerPool() increased from 0 to 1
Error: The parameter $optionalArgs of Google\Cloud\Build\V1\Gapic\CloudBuildGapicClient#deleteWorkerPool() changed from array to no type
Error: Parameter 0 of Google\Cloud\Build\V1\Gapic\CloudBuildGapicClient#deleteWorkerPool() changed name from optionalArgs to name
Error: The number of required arguments for Google\Cloud\Build\V1\Gapic\CloudBuildGapicClient#getWorkerPool() increased from 0 to 1
Error: The parameter $optionalArgs of Google\Cloud\Build\V1\Gapic\CloudBuildGapicClient#getWorkerPool() changed from array to no type
Error: Parameter 0 of Google\Cloud\Build\V1\Gapic\CloudBuildGapicClient#getWorkerPool() changed name from optionalArgs to name
Error: The number of required arguments for Google\Cloud\Build\V1\Gapic\CloudBuildGapicClient#listWorkerPools() increased from 0 to 1
Error: The parameter $optionalArgs of Google\Cloud\Build\V1\Gapic\CloudBuildGapicClient#listWorkerPools() changed from array to no type
Error: Parameter 0 of Google\Cloud\Build\V1\Gapic\CloudBuildGapicClient#listWorkerPools() changed name from optionalArgs to parent
Error: The number of required arguments for Google\Cloud\Build\V1\Gapic\CloudBuildGapicClient#updateWorkerPool() increased from 0 to 1
Error: The parameter $optionalArgs of Google\Cloud\Build\V1\Gapic\CloudBuildGapicClient#updateWorkerPool() changed from array to no type
Error: Parameter 0 of Google\Cloud\Build\V1\Gapic\CloudBuildGapicClient#updateWorkerPool() changed name from optionalArgs to workerPool
Error: Method Google\Cloud\Build\V1\WorkerPool#getProjectId() was removed
Error: Method Google\Cloud\Build\V1\WorkerPool#setProjectId() was removed
Error: Method Google\Cloud\Build\V1\WorkerPool#getServiceAccountEmail() was removed
Error: Method Google\Cloud\Build\V1\WorkerPool#setServiceAccountEmail() was removed
Error: Method Google\Cloud\Build\V1\WorkerPool#getWorkerCount() was removed
Error: Method Google\Cloud\Build\V1\WorkerPool#setWorkerCount() was removed
Error: Method Google\Cloud\Build\V1\WorkerPool#getWorkerConfig() was removed
Error: Method Google\Cloud\Build\V1\WorkerPool#hasWorkerConfig() was removed
Error: Method Google\Cloud\Build\V1\WorkerPool#clearWorkerConfig() was removed
Error: Method Google\Cloud\Build\V1\WorkerPool#setWorkerConfig() was removed
Error: Method Google\Cloud\Build\V1\WorkerPool#getRegions() was removed
Error: Method Google\Cloud\Build\V1\WorkerPool#setRegions() was removed
Error: Method Google\Cloud\Build\V1\WorkerPool#getStatus() was removed
Error: Method Google\Cloud\Build\V1\WorkerPool#setStatus() was removed
Error: The number of required arguments for Google\Cloud\Build\V1\Gapic\CloudBuildGapicClient#createWorkerPool() increased from 0 to 3
Error: The parameter $optionalArgs of Google\Cloud\Build\V1\Gapic\CloudBuildGapicClient#createWorkerPool() changed from array to no type
Error: Parameter 0 of Google\Cloud\Build\V1\Gapic\CloudBuildGapicClient#createWorkerPool() changed name from optionalArgs to parent
Error: The number of required arguments for Google\Cloud\Build\V1\Gapic\CloudBuildGapicClient#deleteWorkerPool() increased from 0 to 1
Error: The parameter $optionalArgs of Google\Cloud\Build\V1\Gapic\CloudBuildGapicClient#deleteWorkerPool() changed from array to no type
Error: Parameter 0 of Google\Cloud\Build\V1\Gapic\CloudBuildGapicClient#deleteWorkerPool() changed name from optionalArgs to name
Error: The number of required arguments for Google\Cloud\Build\V1\Gapic\CloudBuildGapicClient#getWorkerPool() increased from 0 to 1
Error: The parameter $optionalArgs of Google\Cloud\Build\V1\Gapic\CloudBuildGapicClient#getWorkerPool() changed from array to no type
Error: Parameter 0 of Google\Cloud\Build\V1\Gapic\CloudBuildGapicClient#getWorkerPool() changed name from optionalArgs to name
Error: The number of required arguments for Google\Cloud\Build\V1\Gapic\CloudBuildGapicClient#listWorkerPools() increased from 0 to 1
Error: The parameter $optionalArgs of Google\Cloud\Build\V1\Gapic\CloudBuildGapicClient#listWorkerPools() changed from array to no type
Error: Parameter 0 of Google\Cloud\Build\V1\Gapic\CloudBuildGapicClient#listWorkerPools() changed name from optionalArgs to parent
Error: The number of required arguments for Google\Cloud\Build\V1\Gapic\CloudBuildGapicClient#updateWorkerPool() increased from 0 to 1
Error: The parameter $optionalArgs of Google\Cloud\Build\V1\Gapic\CloudBuildGapicClient#updateWorkerPool() changed from array to no type
Error: Parameter 0 of Google\Cloud\Build\V1\Gapic\CloudBuildGapicClient#updateWorkerPool() changed name from optionalArgs to workerPool
Error: Method Google\Cloud\Build\V1\UpdateWorkerPoolRequest#getName() was removed
Error: Method Google\Cloud\Build\V1\UpdateWorkerPoolRequest#setName() was removed

@bshaffer bshaffer merged commit 2a9a4b8 into main Mar 9, 2023
@bshaffer bshaffer deleted the cloudbuild-v1-update branch March 9, 2023 18:28
@release-please release-please bot mentioned this pull request Mar 9, 2023
Merged
bshaffer added a commit that referenced this pull request Mar 21, 2023
@bshaffer
feat: [Build] updates from OwlBrent (#5934)
dda4a34 
PiperOrigin-RevId: 513138925
Source-Link: googleapis/googleapis@187d780
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SurferJeffAtGoogle SurferJeffAtGoogle SurferJeffAtGoogle approved these changes

@saranshdhingra saranshdhingra saranshdhingra approved these changes

Assignees
No one assigned
Labels
breaking change allowed next release PRs to be included in the next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bshaffer @saranshdhingra @SurferJeffAtGoogle