Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add phpstan static analysis #5931

Merged
merged 29 commits into from
May 2, 2023
Merged

chore: add phpstan static analysis #5931

merged 29 commits into from
May 2, 2023

Conversation

bshaffer
Copy link
Contributor

@bshaffer bshaffer commented Mar 7, 2023 •
edited
Loading

@bshaffer
Copy link
Contributor Author

bshaffer commented Mar 8, 2023

The remaining errors should be fixed by #5934 and #5935 🤞

@bshaffer bshaffer added the next release PRs to be included in the next release label Apr 8, 2023
bshaffer
bshaffer commented Apr 8, 2023
View reviewed changes
Storage/src/SigningHelper.php Outdated Show resolved Hide resolved
Spanner/src/KeyRange.php Outdated Show resolved Hide resolved
Spanner/src/Date.php Outdated Show resolved Hide resolved
PubSub/src/MessageBuilder.php Outdated Show resolved Hide resolved
Debugger/src/FormatMessage.php Outdated Show resolved Hide resolved
Debugger/src/SourceLocation.php Outdated Show resolved Hide resolved
Debugger/src/StackFrame.php Outdated Show resolved Hide resolved
Debugger/src/StatusMessage.php Outdated Show resolved Hide resolved
Debugger/src/Variable.php Outdated Show resolved Hide resolved
Firestore/src/FieldPath.php Outdated Show resolved Hide resolved
@bshaffer bshaffer mentioned this pull request Apr 19, 2023
Closed
vishwarajanand
vishwarajanand reviewed Apr 20, 2023
View reviewed changes
phpstan.neon.dist Outdated Show resolved Hide resolved
@bshaffer bshaffer removed the next release PRs to be included in the next release label Apr 22, 2023
@bshaffer bshaffer mentioned this pull request Apr 25, 2023
Merged
2 tasks
@bshaffer
Copy link
Contributor Author

The final 3 errors will be fixed by googleapis/common-protos-php#54

@bshaffer bshaffer marked this pull request as ready for review May 1, 2023 20:42
@bshaffer bshaffer requested review from a team as code owners May 1, 2023 20:42
@bshaffer bshaffer added the next release PRs to be included in the next release label May 1, 2023
vishwarajanand
vishwarajanand approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@vishwarajanand vishwarajanand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing this.

@bshaffer bshaffer merged commit 02f1a73 into main May 2, 2023
@bshaffer bshaffer deleted the add-phpstan branch May 2, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishwarajanand vishwarajanand vishwarajanand approved these changes

Assignees
No one assigned
Labels
next release PRs to be included in the next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bshaffer @vishwarajanand