feat: updates from OwlBrent

Build/.OwlBot.yaml

@@ -1,4 +1,3 @@
 deep-copy-regex:
-    - source: /google/devtools/cloudbuild/v1/.*-php/(.*)
+    - source: /google/devtools/build/v1/.*-php/(.*)
       dest: /owl-bot-staging/Build/v1/$1
-api-name: Build

Build/.gitattributes

@@ -1,8 +1,3 @@
 /*.xml.dist export-ignore
 /tests export-ignore
 /.github export-ignore
-/samples export-ignore
-/.repo-metadata.json export-ignore
-/.OwlBot.yaml export-ignore
-/owlbot.py export-ignore
-/src/**/gapic_metadata.json export-ignore

Build/.repo-metadata.json

@@ -1,7 +1,6 @@
 {
     "distribution_name": "google/cloud-build",
-    "release_level": "preview",
-    "client_documentation": "https://cloud.google.com/php/docs/reference/cloud-build/latest",
-    "library_type": "GAPIC_AUTO",
-    "api_shortname": "cloudbuild"
+    "release_level": "beta",
+    "client_documentation": "http://googleapis.github.io/google-cloud-php/#/docs/cloud-build/latest",
+    "library_type": "GAPIC_AUTO"
 }

Build/CONTRIBUTING.md

@@ -6,5 +6,5 @@ and review pull requests against the main
 repository, which contains all of our client libraries. You will also need to
 sign a Contributor License Agreement. For more details about how to contribute,
 see the
-[CONTRIBUTING.md](https://github.com/googleapis/google-cloud-php/blob/main/CONTRIBUTING.md)
+[CONTRIBUTING.md](https://github.com/googleapis/google-cloud-php/blob/master/CONTRIBUTING.md)
 file in the main Google Cloud PHP repository.

Build/README.md

@@ -4,7 +4,7 @@
 
 [![Latest Stable Version](https://poser.pugx.org/google/cloud-build/v/stable)](https://packagist.org/packages/google/cloud-build) [![Packagist](https://img.shields.io/packagist/dm/google/cloud-build.svg)](https://packagist.org/packages/google/cloud-build)
 
-* [API documentation](https://cloud.google.com/php/docs/reference/cloud-build/latest)
+* [API documentation](http://googleapis.github.io/google-cloud-php/#/docs/cloud-build/latest/build/readme)
 
 **NOTE:** This repository is part of [Google Cloud PHP](https://github.com/googleapis/google-cloud-php). Any
 support requests, bug reports, or development contributions should be directed to
@@ -31,7 +31,7 @@ please see our [gRPC installation guide](https://cloud.google.com/php/grpc).
 
 ### Authentication
 
-Please see our [Authentication guide](https://github.com/googleapis/google-cloud-php/blob/main/AUTHENTICATION.md) for more information
+Please see our [Authentication guide](https://github.com/googleapis/google-cloud-php/blob/master/AUTHENTICATION.md) for more information
 on authenticating your client. Once authenticated, you'll be ready to start making requests.
 
 ### Version

Build/VERSION

@@ -1 +1 @@
-0.4.0
+0.1.1

Build/composer.json

@@ -6,8 +6,7 @@
     "autoload": {
         "psr-4": {
             "Google\\Cloud\\Build\\": "src",
-            "GPBMetadata\\Google\\Devtools\\Cloudbuild\\": "metadata",
-            "GPBMetadata\\Google\\Devtools\\Build\\": "metadata"
+            "GPBMetadata\\Google\\Devtools\\Cloudbuild\\": "metadata"
         }
     },
     "autoload-dev": {
@@ -27,8 +26,9 @@
         "google/gax": "^1.7.0"
     },
     "require-dev": {
-        "phpunit/phpunit": "^4.8|^5.0|^8.0",
-        "yoast/phpunit-polyfills": "^1.0"
+        "phpunit/phpunit": "^4.8|^5.0",
+        "google/cloud-core": "^1.31",
+        "phpdocumentor/reflection": "^3.0"
     },
     "suggest": {
         "ext-grpc": "Enables use of gRPC, a universal high-performance RPC framework created by Google.",

Build/owlbot.py

@@ -30,23 +30,33 @@
 # Added so that we can pass copy_excludes in the owlbot_main() call
 _tracked_paths.add(src)
 
-php.owlbot_main(
-    src=src,
-    dest=dest,
-    copy_excludes=[
-        src / "**/[A-Z]*_*.php",
-        src / "**/*GrpcClient.php",
-    ]
-)
+php.owlbot_main(src=src, dest=dest)
+
+
+
+# document and utilize apiEndpoint instead of serviceAddress
+s.replace(
+    "**/Gapic/*GapicClient.php",
+    r"'serviceAddress' =>",
+    r"'apiEndpoint' =>")
+s.replace(
+    "**/Gapic/*GapicClient.php",
+    r"@type string \$serviceAddress\n\s+\*\s+The address",
+    r"""@type string $serviceAddress
+     *           **Deprecated**. This option will be removed in a future major release. Please
+     *           utilize the `$apiEndpoint` option instead.
+     *     @type string $apiEndpoint
+     *           The address""")
+s.replace(
+    "**/Gapic/*GapicClient.php",
+    r"\$transportConfig, and any \$serviceAddress",
+    r"$transportConfig, and any `$apiEndpoint`")
 
-# remove class_alias code
+# Change the wording for the deprecation warning.
 s.replace(
-    "src/V*/**/*.php",
-    r"^// Adding a class alias for backwards compatibility with the previous class name.$"
-    + "\n"
-    + r"^class_alias\(.*\);$"
-    + "\n",
-    '')
+    'src/*/*_*.php',
+    r'will be removed in the next major release',
+    'will be removed in a future release')
 
 ### [START] protoc backwards compatibility fixes
 
@@ -58,6 +68,12 @@
      */
     private $""")
 
+# prevent proto messages from being marked final
+s.replace(
+    "src/**/V*/**/*.php",
+    r"final class",
+    r"class")
+
 # Replace "Unwrapped" with "Value" for method names.
 s.replace(
     "src/**/V*/**/*.php",

Build/phpunit-snippets.xml.dist

@@ -0,0 +1,19 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<phpunit
+  bootstrap="./vendor/google/cloud-core/snippet-bootstrap.php"
+  colors="true"
+  printerClass="Google\Cloud\Core\Testing\Snippet\Coverage\ResultPrinter">
+  <testsuites>
+    <testsuite>
+      <directory>tests/Snippet</directory>
+    </testsuite>
+  </testsuites>
+  <filter>
+    <whitelist>
+      <directory suffix=".php">src</directory>
+      <exclude>
+        <directory suffix=".php">src/V[!a-zA-Z]*</directory>
+      </exclude>
+    </whitelist>
+  </filter>
+</phpunit>

Build/phpunit-system.xml.dist

@@ -0,0 +1,16 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<phpunit bootstrap="./vendor/google/cloud-core/system-bootstrap.php" colors="true">
+  <testsuites>
+    <testsuite>
+      <directory>tests/System</directory>
+    </testsuite>
+  </testsuites>
+  <filter>
+    <whitelist>
+      <directory suffix=".php">src</directory>
+      <exclude>
+        <directory suffix=".php">src/V[!a-zA-Z]*</directory>
+      </exclude>
+    </whitelist>
+  </filter>
+</phpunit>

Build/phpunit.xml.dist

@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <phpunit colors="true">
   <testsuites>
-    <testsuite name="Unit Test Suite">
+    <testsuite>
       <directory>tests/Unit</directory>
     </testsuite>
   </testsuites>