Firestore: Adding FieldMask support to GetAll() #4017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
schmidt-sebastian
force-pushed
the
mrschmidt-fieldmask
branch
from
95c0671
to
2287ccb
Compare
pongad
reviewed
Nov 19, 2018
| static final DocumentMask EMPTY_MASK = new DocumentMask(new TreeSet<FieldPath>()); | ||
| /** A FieldMask can be used to limit the number of fields returned by a `getAll()` call. */ | ||
| public final class FieldMask { | ||
| static final FieldMask EMPTY_MASK = new FieldMask(new TreeSet<FieldPath>()); | ||
|
|
||
| private final SortedSet<FieldPath> fieldPaths; // Sorted for testing. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| */ | ||
| @Nonnull | ||
| ApiFuture<List<DocumentSnapshot>> getAll( | ||
| @Nonnull DocumentReference[] documentReferences, @Nullable FieldMask fieldMask); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Generally LGTM with some questions, but Yoshi should sign off. |
chingor13
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
This was referenced Dec 6, 2018
snehashah16
added a commit
that referenced
this pull request
Feb 3, 2019
* Fix: writeAtLeastOnce should use a ReadWriteSession (#3882) * Fix search folder for BQDT synth output (#3878) * Bigtable: Add integration test to test nonexistent row handling (#3870) * Fix #3292 (#3875) * Regenerate video-intelligence client (#3865) * Release v0.69.0 (#3890) * Bump next snapshot (#3892) * Bigtable: fix admin tests to able to run concurrently (#3895) * Fix ApiFutures.addCallback() (#3886) ApiFutures.addCallback() now requires a third argument (a non-direct executor). Ref: https://github.com/googleapis/api-common-java/blob/master/src/main/java/com/google/api/core/ApiFutures.java * Regenerate logging client with test fixes (#3907) * Regenerate DLP Client (#3823) * Regenerate vision client: Adds product search (#3888) * Regenerate vision client * vision proto libraries need com.google.api:api-common compile dependency * Regenerate dataproc client (#3906) Unsets empty list of retry status codes * Regenerate monitoring client (#3908) Unsets empty list of no-retry status codes * Move BOM info to right after Quick Start (#3555) * Move BOM info to right after Quick Start * split version management * change to old version combinations * Update README.md * Spanner gapic migration (#3881) * Add GapicSpannerRpc stub (#3016) * spanner: implement partitionRead (#3022) * spanner: implement LRO methods using GAPIC stub (#3039) * Add implementation to:listInstances, listInstanceConfigs, listDatabases, getInstance, getInstanceConfigs, getDatabase, dropDatabase, deleteInstance, getDatabaseDdl (#3043) * spanner: move admin clients to GAPIC stub (#3067) * Spanner: migrate all unary call methods to gapic and inject headers (#3112) * Spanner: migrate streaming methods to gapic (#3139) * Spanner gapic migration lro methods (#3166) Migrate longrunning methods to GAPIC including: createDatabase, updateDatabaseDdl, createInstance, and updateInstance. * Make ChannelPool work (#3258) * Spanner gapic migration error augmentation with interceptor (#3304) * Add interceptors (#3346) * Clean up Spanner before merging to master (#3362) * Spanner Gapic Migration: fix updateDatabaseDdl (#3403) * Regenerate compute client (#3916) Adds interconnect features * Regenerate dlp client (#3917) Add excluded_fields to BigQueryOptions * Add a feature to list the buckets (#3915) Also, update the README to reflect recent update to pseudoDirs. * Pubsub: use gapic client (#3581) * bump checkstyle version to build on Java 9 The version of checkstyle we currently use uses tools.jar which is removed from Java 9 and above as part of Project Jigsaw. This commit uses a newer version of checkstyle that does not use tools.jar. Running `mvn checkstyle:checkstyle` succeeded.� * maybe this will be java 7 compat...? * pubsub: use GAPIC stub * fix merge * pr comment * Update CODEOWNERS fallback match should be last * Storage NIO: Stop leaving leftover buckets in IT (#3898) * Stop leaving leftover buckets in ITGcsNIO This integration test now deletes all the buckets it creates. The issue was that requester-pays buckets couldn't be deleted by the existing code. This PR updates RemoteStorageHelper so it can be given a userProject for requester-pays buckets. * Don't set userProject if empty, add test RemoteStorageHelper now doesn't set the userProject option if it's empty. Also, added testForceDeleteRetriesWithUserProject unit test. * Logging: Add a traceSampled field to the LogEntry class. (#3863) The new field was added to the Stackdriver LogEntry protocol buffer message in googleapis/googleapis@7b34e5a#diff-a51916a680df6453b6d86586cd7d63f9R149. * Bigtable: add sync methods (#3856) * New Client: Cloud Scheduler (#3913) * Add synth.py for generating cloud scheduler client * Add generated cloud scheduler code * Fix proto/grpc artifact names * Add versions and pom.xml files * Update list of stub packages in google-cloud-clients * Add README * Exists method added in BigtableInstanceAdminClient (#3891) * Firestore: Validate that at least one argument is provided for Cursor (#3900) * Release google-cloud-java v0.70.0 (#3921) * Bump next snapshot (#3922) * bigtable emulator (#3840) This allows customers to easily interact with the bigtable emulator. Currently the Bigtable emulator is implemented in go. It is a fairly complex bit of code that would be very difficult to replicate in java. This makes it very difficult for users to interact with it in a java project. This PR attempts to make things easier for the user by wrapping the golang emulator in a jar and providing a JUnit rule to simplify lifecycle management of the emulator. It's implemented as 2 artifacts: - google-cloud-gcloud-maven-plugin: a maven plugin that can download artifacts from the gcloud sdk repo and add them as resources to a jar. This avoids the need to check in binaries into google-cloud-java and makes sure that the binaries are up to date. - google-cloud-bigtable-emulator: This uses the maven plugin to bundle the bigtable emulator in a jar and adds a java wrapper around the binary. The wrapper was extracted from the existing bigtable client integration tests: https://github.com/googleapis/google-cloud-java/blob/master/google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/it/env/Emulator.java * Update README to suggest importing BOM (#3269) * Import BOM @garrettjonesgoogle * google-cloud-bom * Update README.md * Spanner: use WatchdogProvider (#3923) * change to watchdog provider * Bigtable: [Breaking change] listTables() now returns relative table names (#3696) * Bigtable: be consistent and don't expose absolute table names * fix merge * fix merge * Update container synth script for new artman config name (#3925) * New Client: BigQuery Storage (#3935) * New Client: Cloud Security Command Center (#3885) * Add synth.py script and generate files * Add versions for release management, add README.md, pom.xml * Add google-cloud-security center as module for google-cloud-clients * Add securitycenter to google-api-grpc modules * Add securitycenter artifacts to the bom * security center depends on iam protos * Regenerate Security Center models/stubs * Fix artifact versions * Fix artifact versions * Fix artifact versions * Add Kokoro nightly build configs (#3926) * Add namespace and schema to settings.xml (#3941) Updates the release setup guide. * Regenerate bigquerystorage client (#3939) Adds documentation strings * fix: google-cloud-clients/pom.xml to reduce vulnerabilities (#3943) The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JAVA-COMMONSFILEUPLOAD-30401 * Regenerate speech client (#3933) Adds `result_end_time` to `StreamingRecognitionResult` * Update google-auth-library-java, apiary core libraries (#3945) * Update google-auth-library-java, apiary core libraries * Fix static import from shaded guava package * Upgrade gax, grpc and guava dependencies (#3980) * Bump gax version to 1.35.0 and guava to 26.0-android * Update grpc dependency to 1.16.1 * Add temporary, specific animal-sniffer-annotation version * Release v0.71.0 (#3978) * Bump next snapshot (#3981) * Fix BigQuery NullPointerException when estimatedFields is empty (#3984) * BigQuery client throws NullPointerException when estimatedFields is empty * fix formatting * Regenerate container client (#3979) * Cloud Asset fix README links (#3985) Updated Cloud Asset links to point to the Cloud Asset API page. * Add synth metadata for many clients (#4020) * Storage: Added feature to change host name of signed url (#3910) * #3140 feature added to change hostname of generated Url * add test case * removed overload method and add method withExtHostName in SignUrlOption * rename EX_HOST to SERVICE_ENDPOINT,rename withExtHostName to withHostName and used google-java-formatter * update as per feedback * fix formatting * update comments * update Signed URLs Comment * Regenerate websecurityscanner client (#4080) * Delay download of Bigtable emulator (#4102) * Add gcloud.download.skip option for google-cloud-gcloud-maven-plugin * Skip emulator download when doing the initial install * Rename `skip` to `shouldSkipDownload` * [Snyk] Fix for 1 vulnerable dependencies (kr.motd.maven:os-maven-plugin) (#4097) * fix: google-cloud-util/google-cloud-compat-checker/pom.xml to reduce vulnerabilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JAVA-ORGCODEHAUSPLEXUS-31521 * Add guava dependency in google-cloud-compat-checker Previously, the kr.motd.maven:os-maven-plugin brought in a dependency that brought in guava. This artifact explicitly uses guava collections so we need to add the dependency here. * fix: google-cloud-testing/google-cloud-gcloud-maven-plugin/pom.xml to reduce vulnerabilities (#4100) The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JAVA-ORGCODEHAUSPLEXUS-31521 * Trace: list response returns empty list instead of null (#4079) * Regenerate speech client: remove unused imports (#4077) * Update generated code: List responses return empty list instead of null (#4104) * Regenerate automl client * Regenerate bigquerydatatransfer client * Regenerate bigtable-admin client * Regenerate compute client * Regenerate containeranalysis client * Regenerate dataproc client * Regenerate dialogflow client * Regenerate dlp client * Regenerate errorreporting client * Regenerate firestore client * Regenerate kms client * Regenerate logging client * Regenerate redis client * Regenerate scheduler client * Regenerate securitycenter client * Regenerate spanner client * Regenerate tasks client * Regenerate language client: remove unused imports (#4071) * Datastore: Add `skippedResults` in `QueryResults` (#4093) * Fix #3279 google-cloud-datastore Java library exposes too little of the information in query results * fix typo in comment * BigQuery Storage: Add shim layer settings and configuration (#4022) * Create a shim layer for the BigQuery Storage API. This change adds a simple shim layer to the BigQuery Storage API client. It is modeled after the shim layer in the Cloud Bigtable client, but unlike that implementation, it does not create chained instances of unary and server-streaming callables to perform translation; instead, its parameters are simple pass-throughs to the underlying gRPC client stub. The shim currently does nothing but read default values from the base client layer and pass them back through. * Set the default gRPC inbound message size. This change sets the default value for the maximum inbound message size in the BigQuery Storage API client. A ReadRowsResponse object can contain serialized row block of up to 10 MB in size if the underlying row(s) are sufficiently large. * Update the default timeout value for ReadRows. This change modifies the default client-side timeout value for the ReadRows API. ReadRows calls can last for long periods in the case of large tables. The default timeout value is set to a full day, which is the duration for which a read session is valid. * Add a resumption strategy for ReadRows. This change modifies the configuration for the ReadRows API to add a resumption strategy, allowing the connection to be resumed transparently in the case of transient errors. * Spanner: fix code formatting (#4105) * Storage NIO: Add new retry options in CloudStorageConfiguration (#3869) * Put new retry options in CloudStorageConfiguration Add retriableHttpCodes and reopenableExceptions so the user can, if they choose, customize the conditions under which we retry an access or reopen a channel after an exception closed it. This can be handy if a cloud provider starts transiently throwing exceptions that would normally indicate a fatal condition, but which in practice will pass if retried. The backoff logic in retries / reopens in unmodified. * Clean up dead code line * retriable -> retryable (in NIO Cloud Storage code) Also add a few basic tests to make sure the retryable options do what we expect. * Update testListFilesInRootDirectory to match reality In the built-in UNIX filesystem, the newDirectoryStream method will return absolute paths if given absolute paths as input, and relative paths if given relative paths as input. We're now seeing this too for the NIO Cloud Storage provider (this is a good thing), so I updated this test to reflect this new reality. * remove unused import * Add boilerplate file header * Keep old ctor, just @deprecated * Add back the *other* ctor that needs to be deprecated * add @deprecated outside of comment * Regenerate IoT client (#4069) Adds new API endpoints for: * sendCommandToDevice * bindDeviceToGateway * unbindDeviceFromGateway * Moving surefire-junit4 out of the dependency lists to allow others to better run tests. (#4058) * Try adding maven-surefire-plugin as a plugin to pull the correct surefire-junit. * Let's move the surefire-junit4 out of util as well to be consistant. * Fix indentation in pom * Regenerate dataproc client - Adds workflow templating (#4110) * Add missing fields on MonitoredResourceUtil (#3887) * added missing fields #3559 * Fix indentation * Add helpers to convert core Date class with java.util.Date class (#3911) * #3157 add methods toDate, fromDate * resolved test case Date.getYear() * update as per feedback * Update javadoc string * Bigtable: publish emulator to maven central (#4106) * Bigtable: publish emulator to maven central * make sure nexus plugin is not disabled * Release v0.72.0 (#4113) * Adding FieldMask support to GetAll() (#4017) * Bump next snapshot (#4118) * Logging: Allow deferred formatting for trace and spanId (#3661) * Allow deferred formating for trace and spanId. * Add back setTrace(String) and setSpanId(String) for binary compatibility * Update HttpStorageRpc.java (#4109) * Make TestServiceFactory and TestServiceRpcFactory interfaces public (#4112) * Java 11 compatibility (#3821) * Add the javax.annotation-api as a compile scope to the google-api-grpc projects * Upgrade maven-compiler-plugin 3.5.1->3.7.0 and maven-jar-plugin 2.6->3.1.0 * Add annotation-api compile dependency to google-cloud-clients * Fix objensis version 3.1.0->2.6 * Fix service option test visibility * Temporarily using Java 7 build to test Java 11 * Restore the java 7 test to use the java 7 image * Add release profile to bigtable emulator (#4119) * Release v0.72.0 * Add release profile to bigtable emulator * Add release profile to bigtable emulator * Add lint test and format generated code (#4114) * Add lint Kokoro tests * synthtool will now run the java formatter after generating the files * BigQuery: Fix TableId behaviour for non default BigQueryClient project (#4115) * Fixes create, update and delete methods * remove comments * Fix formatting * Run google-java-format on all artifacts (#4121) * Run google-java-format on all artifats * Format some missed files * Add more missed files * Fix formatting issues from the merge * Pub/Sub: Update ApiFutures.addCallback() to take 3 arguments (#4120) * Update ApiFutures.addCallback() * use DirectExecutor * nit * use directExecutor * run formatter * Update maven-javadoc-plugin to 3.0.1 and disable doclint. (#4167) 3.0.0 introduced a setting to disable doclint via config instead of a necessitating a conditional profile based on the java version. * Remove the old clients compatibility chart. (#4163) Any of these clients in question would be using versions older than a year and should upgrade. * BigQuery: insertAll always retries operation (#4165) * fix #3321 BigQuery insertAll always retries operation * Update Spanner description for GA (#4174) * Storage: Close response body after request (#4116) * 4107: Disconnect response after request * 4107: Added integration test testWriteChannelWithConnectionPool * 4107: Renamed blobName. * Fix lint * Storage: Fixed link to StorageExamples page (#4173) * 4169: Fixed link to StorageExamples page * 4169: Fixed Line 39 An App Engine application that manages a virtual bookshelf. * 4169: Removed WS * Integration test deflake (#4176) * Bump integration test timeout to 15 minutes from 10 minutes * Call the maven test directly - no need for verify_single_it.sh * provide spanner.testenv.instance property from Kokoro config * Bump integration test timeout to 20 minutes * Fix syntax * Remove exclusions for guava-jdk5 and google-api-client (#4177) We've updated the apiary clients to versions that no longer need these exclusions. * Storage: Give users the ability to disable gzip content encoding to increase throughput (#4170) * 3822: Added BlobTargetOption for user to set disabledGzipContent true * 3822: Changed method comment * 3822: Changed method comment with more explanation * 3822: Fixed comments after review. Added unit test * 3822: Fixed formatting errors in Storage class * 3822: Fixed formatting errors in StorageImplTest class * Spanner: Handle AbortedExceptions that occur before commit (#4181) * spanner: Handle AbortedExceptions that occur before commit The current TransactionRunner code checks for aborted transactions by using the isAborted() function. This function returns the value of "aborted" that is only set when processing resultSets. This does not work for DML which only uses the resultSet stats and does not actually call ResultSet.next(). This patch adds an additional check for the aborted exception type and retries such transactions. * throw before executeUpdate, verify flag is false after test * Update google-cloud-clients/google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITDMLTest.java Co-Authored-By: nithinsujir <[email protected]> * Put the spanner test instance config back * Document purpose of test-jar and testlib dependencies (#4164) * google-cloud-bom should not need google-cloud-core test-jar (#4168) * google-cloud-bom should not need google-cloud-core test-jar * Need to declare google-cloud-core version still * testing modules need to specify the google-cloud-core test-jar version * Regenerate pubsub client: Fix empty list returns (#4159) * Regenerate pubsub client * Fix the default maxInboundMessageSize config via synth * BigQuery: Allow job to extract or load table across projects (#4183) * Fix #3924 ExtractJobConfiguration's setProjectId makes cross-project BQ extracts impossible * Bigtable: fix emulator publishing (#4189) * Bigtable: fix emulator publishing Currently the emulator can't be used because it's parent pom is not published. THis PR removes the parent and copies the relevant bits into the emulator's pom Fixes #4187 * Add a couple more bits from the parent pom * oops * Release google-cloud-java v0.73.0 (#4191) * Release v0.73.0 * Fix version replacements * Move Spanner to GA section * Fix doclint option * Fix pom issues for Bigtable emulator * Bump next snapshot (#4192) * Add Container synth.metadata (#4193) * Add Pub/Sub synth.metadata (#4194) * Update variable naming. (#4199) * Update api-common-java javadoc link. (#4200) * Regenerate compute client: adding beta config classes/options (#4201) * Regenerate dataproc client: Adding beta APIs for workflow templates (#4202) * NIO: Enabled blocked tests. Fixed testCantCreateWithoutUserProject test. (#4182) * 3448: Ublocked tests. Fixed testCantCreateWithoutUserProject test. * 3448: Fixed code format. * 3448: Fixed code format issue * Bigtable: readRow methods added with Query as argument (#4092) * Regenerate automl client - No substantive changes (#4209) * Regenerate compute client (#4210) This PR was generated using Autosynth. 🌈 Adding new resource types and methods from updated Discovery doc. * Fix setProjectId for insertAll (#4196) * Pubsub: Test for blocking push subscriptions for vpc-sc enabled projects (#4214) * Bump gax version to 1.35.1 (#4217) * Add IamCredentials client (#4216) * Add IamCredentials client * Fix pom versions and formatting * Remove classes that were in my cache directory from a bad previous generation * Remove some more files cached from a bad synth * Fix xml formatting * Fix xml formatting * Update README descriptions and links * Fix generated code lint * Synth script should format java code * Release v0.74.0 (#4222) * Bump next snapshot (#4224) * BigQuery : Fix setProjectId (#4227) * Fix Change in TableId behaviour for non default BigQueryClient project * Fix setProjectId for TableInfo * add test cases and fix writechannel * fix format code * Add BadRecords to LoadStatistics (#4230) * Add script to help bootstrap new client libraries (#4111) * Add new client python script * Add requirements.txt, convert to use attrs * Start new artifact versions at 0.0.0-alpha. Next release will bump version * Switch to pathlib * Move main execution into main() * Standardize quotes to double-quotes * Update docstrings * Fix Path vs. string types when reading/writing files * Update synth.py template to include the java formatter * Update javadoc link for api-common-java. (#4236) * IAMCredentials: Fix name/description in pom (#4238) * Regenerate google-cloud-compute (#4213) Generation of Compute client with latest gapic-generator changes. This also contains one set of manual changes in ITComputeTest, where we remove the hack needed to parse a ResourceName string. * Ignore testRotateFromCustomerEncryptionToKmsKeyWithCustomerEncryption while we work out backend change (#4266) * Fix NPE in BQ's StandardTableDefinition (#4247) * Bigtable: add a separate callable for point reads (#4264) * Spanner: closed watch-dog daemon threads spawned by Spanner client (#4263) * Fixed Issue - shutting-down WatchDog daemon threads spawned by Spanner client * Fixed Issue - shutdown watchDog daemon threads spawned by Spanner client * Minor code formatting * Fixed Kokoro code format issue * Fix Kokoro release jobs (#4225) * Fix Kokoro release jobs. Needs loopback pinentry-mode * Skip install on deploy * skip stagingProfileId * Capture built artifacts * Enable promote/drop jobs via environment variable * Fix directory path and use -B for drop/release * promote/drop need the settings file * Fix path to settings file * Update RELEASING documentation to use the Kokoro jobs * Pub/Sub: Add message abandonment (#4250) * add abandonment * add unit test for abandon * update forget() to stop extending deadline * BigQuery: Fix Maximum Bytes Billed property. (#4262) * Fix Maximum Bytes Billed * remove whitespace * Update UsePubSubEmulatorSnippet.java (#4256) * Logging: disable severity based flush on write by default (#4254) * fix #3880 #2796 disable automatic flush on write to avoid hanging and leaking threads as grpc also uses this appender which goes in to deadlock over time. * fix formatting * add flush before listing * Docs: Fix maven site generation (#4232) The configuration for aggregate changed from an attribute to a report * Bigtable: deprecate the use of typesafe names (#4257) * Bigtable: deprecate the use of typesafe names Unfortunately typesafe names create more issues for bigtable than they solve. A lot of the time users need to use both bigtable data & admin apis. Unfortunately, those apis define the same names in different namespaces. This forces users to use fully qualified names which is ugly. Also, absolute names don't benefit the bigtable client because the client is anchored at the instance and all names end up being relative * fix docs * format code * Fixed cannot call public methods in via reflection (#4249) * modified package-private to public * update format for storage/Option.java * BigQuery : Fix numBytes, numRows in TableInfo/Table (#4271) * Fix NumBytes and NumRows * update NumBytes and NumRows * remove setter * update methods and resolved test case * Cloud Bigtable: helloWorld sample (#4274) * helloWorld sample * test class modified * format change in ITHelloWorld * Add .tmpl extension for README.md so releasetool is not confused (#4280) * Release v0.75.0 (#4282) * Bump next snapshot (#4286) * Fix #4284 NPE for getZone (#4289) * Regenerate securitycenter client (#4290) * Bigtable admin: deprecate typesafe names part 2 (#4258) * Bigtable admin: deprecate typesafe names This is a followup on #4257: Unfortunately typesafe names create more issues for bigtable than they solve. A lot of the time users need to use both bigtable data & admin apis. Unfortunately, those apis define the same names in different namespaces. This forces users to use fully qualified names which is ugly. Also, absolute names don't benefit the bigtable client because the client is anchored at the instance and all names end up being relative * format code * fix year * Regenerate iamcredentials client (#4277) * Revert "Pub/Sub: Add message abandonment (#4250)" (#4297) This reverts commit 6e2c2dd. * updated links (#4287) * updated links * updated link * added new line * Release v0.76.0 (#4298) * Regenerate dataproc client (#4301) * Bump next snapshot (#4300) * Cloud Bigtable: instanceAdmin sample (#4299) * instanceAdmin sample and tests * comments added * instanceAdminExample changes * renamed variables * changes * Regenerate securitycenter client (#4311) * 3540: Used transformer for shaded plugin (#4305) * Added Query#fromProto to convert protobuf ReadRowsRequest (#4291) * Adding Query.fromProto * Adding Query.fromProto * adding changes as per feedback * updated javadoc as per feedback * reformatted Query & QueryTest.java * Bigquery: corrected equality check on subclasses of StringEnumValue (#4283) * Bigquery: corrected equality check on subclasses of StringEnumValue * update format for FieldTest.java * Fix #4269 update metata url to FQDN (#4278) * 4152: Added checking PAGE_TOKEN from options (#4303) * 3918: Added checking of attributes size for 0. Added unit test (#4304) * Bigtable: Merge bigtable-admin into the bigtable artifact (#4307) * Bigtable: merge bigtable-admin into the bigtable artifact * split exclusion change for future PR * fix admin pathes * fix deprecation warning * fix synth script * fix generated file * temporarily re-add kokoro scripts (and point them to the merged artifact) until the jobs have been removed * Remove dep from examples * fix admin integration tests * revert stray fix (will be added to a separate PR) * fix int tests * don't double format the code * fix up docs * Regenerate PubSub: documentation updates (#4293) * Regenerate monitoring client (#4316) * Regenerate bigtable client (#4318) * 3822: Fixed setDisableGZipContent call (#4314) * 3822: Fixed setDisableGZipContent call * 3822: Changes after review * Regenerate speech client: enable multi-channel features (#4317) * Release v0.77.0 (#4324) * Created enum Region.java to retrieve Regions without doing request. (#4309) * Bump next snapshot (#4325) * Bigtable: fix handling of unset rpc timeouts (#4323) When the rpc timeout is zero, then it should be treated as disabled not actual 0 * Bigtable: Expose single row read settings (#4321) * exposing ReadRowSettings thru BigtableDataSettings * fixed typo error * Regenerate compute client (#4327) * Regenerate speech client (#4328) * Update README version to use bom version (#4322) * BigQuery: Fix NPE for null table schema fields (#4338) * Add failing test for empty table schema * Fix NPE if table schema returns null for fields * Bump gax, grpc & opencensus version (#4336) * Cloud Bigtable: HelloWorld sample updates (#4339) * comments added in HelloWorld and ITHelloWorld * removed typsafe name * separate properties for bigtable.project and bigtable.instance * separate properties for bigtable.project and bigtable.instance (#4346) * Pub/Sub: default values in batch settings comments (#4350) * Pub/Sub: default values in batch settings comments Ref: https://github.com/googleapis/gax-java/blob/master/gax/src/main/java/com/google/api/gax/batching/BatchingSettings.java * Verbose comment * Update maven-surefire-plugin to 3.0.0-M3 to fix Java 8 classloader (#4344) * Update maven-surefire-plugin to 3.0.0-M3 to fix Java 8 classloader * Update failsafe plugin to 3.0.0-M3 too * Specify maven-surefire-plugin version in bigtable-emulator * Bigtable: Fixing a typo for KeyOffSet#geyKey to getKey (#4342) * Regenerate spanner client (#4332) * Spanner: remove junit from compile dependencies (#4334) * Firestore: change timestampsInSnapshots default to true. (#4353) BREAKING CHANGE: The `areTimestampsInSnapshotsEnabled()` setting is now enabled by default so timestamp fields read from a `DocumentSnapshot` will be returned as `Timestamp` objects instead of `Date`. Any code expecting to receive a `Date` object must be updated. * Regenerate clients with updated copyright year (#4382) * Regenerate asset client * Regenerate automl client * Regenerate bigquerydatatransfer client * Regenerate bigquerystorage client * Regenerate bigtable client * Regenerate container client * Regenerate containeranalysis client * Regenerate dataproc client * Regenerate dialogflow client * Regenerate dlp client * Regenerate errorreporting client * Regenerate iamcredentials client * Regenerate iot client * Regenerate kms client * Regenerate language client * Regenerate logging client * Regenerate monitoring client * Regenerate os-login client * Regenerate pubsub client * Regenerate redis client * Regenerate securitycenter client * Regenerate speech client * Regenerate tasks client * Regenerate trace client * Regenerate video-intelligence client * Regenerate websecurityscanner client * Release google-cloud-java v0.78.0 (#4386) * Regenerate compute client (#4359) * Cloud Bigtable: tableAdmin sample (#4313) * tableAdmin sample and tests * comments added * files renamed and other edits * some changes in TableAdminExample and tests * fixed timestamp to base 16 * separate properties for bigtable.project and bigtable.instance * Regenerate scheduler client (#4294) * Regenerate spanner client (#4388) * Bump next snapshot (#4391) * Regenerate asset client (#4395) * Regenerate scheduler client (#4396) * Firestore: Include a trailing /documents on root resource paths (#4352) This is required for v1 and accepted in v1beta1. Port of googleapis/nodejs-firestore@52c7381 * Release v0.79.0 (#4402) * Removing some unused dependencies (#4385) * Removing some unused dependencies Also, reducing scope of auto-value to provided. * Restoring Firestore auto-value * Removing more instances of easymock. * Removing non-deprecated uses of joda time. (#4351) * Removing non-deprecated uses of joda time. This works towards #3482 * Update pom.xml * Ran `mvn com.coveo:fmt-maven-plugin:format` * Fixing a bad merge * Bump next snapshot (#4405) * fix shading (#4406) * Fixing some deprecation warnings (#4390) * fixing some deprecation warnings * updated comment * BigQuery : Fix Location configurable at BigQueryOptions (#4329) * Fix Location configurable from BigQueryOptions * modified code * modified code and add test case * removed unused location * Generate Firestore API v1 (#4410) * Bigtable: make row & cell ordering more consistent. (#4421) * Bigtable: make row & cell ordering more consistent. * RowCells should always be ordered in lexicographically by family, then qualifier and finally by reverse chronological order * Although rows will always be ordered lexicographically by row key, they should not implement Comparable to avoid confusion when compareTo() == 0 and equals() is false. Instead that ordering was moved to a separate comparator. * Add helpers to filter cells by family & qualifier * tweaks * code style * code style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users to specify the DocumentMask proto and to reduce the number of fields returned in a Firestore read operation.
This is a port of googleapis/nodejs-firestore#443. The API surface is slightly different, as the JavaScript implementation doesn't feel very fitting for Java. It would have ended up as
I am not 100% sold that the API surface in this PR is the best either (should we use a List instead of an Array?), so feedback would be appreciated. We are not matching a client API.