Merge request #4436

snehashah16 · 2019-02-03T07:15:57Z

No description provided.

ApiFutures.addCallback() now requires a third argument (a non-direct executor). Ref: https://github.com/googleapis/api-common-java/blob/master/src/main/java/com/google/api/core/ApiFutures.java

* Regenerate vision client * vision proto libraries need com.google.api:api-common compile dependency

Unsets empty list of retry status codes

Unsets empty list of no-retry status codes

* Move BOM info to right after Quick Start * split version management * change to old version combinations * Update README.md

* Add GapicSpannerRpc stub (#3016) * spanner: implement partitionRead (#3022) * spanner: implement LRO methods using GAPIC stub (#3039) * Add implementation to:listInstances, listInstanceConfigs, listDatabases, getInstance, getInstanceConfigs, getDatabase, dropDatabase, deleteInstance, getDatabaseDdl (#3043) * spanner: move admin clients to GAPIC stub (#3067) * Spanner: migrate all unary call methods to gapic and inject headers (#3112) * Spanner: migrate streaming methods to gapic (#3139) * Spanner gapic migration lro methods (#3166) Migrate longrunning methods to GAPIC including: createDatabase, updateDatabaseDdl, createInstance, and updateInstance. * Make ChannelPool work (#3258) * Spanner gapic migration error augmentation with interceptor (#3304) * Add interceptors (#3346) * Clean up Spanner before merging to master (#3362) * Spanner Gapic Migration: fix updateDatabaseDdl (#3403)

Adds interconnect features

Add excluded_fields to BigQueryOptions

Also, update the README to reflect recent update to pseudoDirs.

* bump checkstyle version to build on Java 9 The version of checkstyle we currently use uses tools.jar which is removed from Java 9 and above as part of Project Jigsaw. This commit uses a newer version of checkstyle that does not use tools.jar. Running `mvn checkstyle:checkstyle` succeeded.� * maybe this will be java 7 compat...? * pubsub: use GAPIC stub * fix merge * pr comment

fallback match should be last

* Stop leaving leftover buckets in ITGcsNIO This integration test now deletes all the buckets it creates. The issue was that requester-pays buckets couldn't be deleted by the existing code. This PR updates RemoteStorageHelper so it can be given a userProject for requester-pays buckets. * Don't set userProject if empty, add test RemoteStorageHelper now doesn't set the userProject option if it's empty. Also, added testForceDeleteRetriesWithUserProject unit test.

The new field was added to the Stackdriver LogEntry protocol buffer message in googleapis/googleapis@7b34e5a#diff-a51916a680df6453b6d86586cd7d63f9R149.

* Add synth.py for generating cloud scheduler client * Add generated cloud scheduler code * Fix proto/grpc artifact names * Add versions and pom.xml files * Update list of stub packages in google-cloud-clients * Add README

…#3900)

This allows customers to easily interact with the bigtable emulator. Currently the Bigtable emulator is implemented in go. It is a fairly complex bit of code that would be very difficult to replicate in java. This makes it very difficult for users to interact with it in a java project. This PR attempts to make things easier for the user by wrapping the golang emulator in a jar and providing a JUnit rule to simplify lifecycle management of the emulator. It's implemented as 2 artifacts: - google-cloud-gcloud-maven-plugin: a maven plugin that can download artifacts from the gcloud sdk repo and add them as resources to a jar. This avoids the need to check in binaries into google-cloud-java and makes sure that the binaries are up to date. - google-cloud-bigtable-emulator: This uses the maven plugin to bundle the bigtable emulator in a jar and adds a java wrapper around the binary. The wrapper was extracted from the existing bigtable client integration tests: https://github.com/googleapis/google-cloud-java/blob/master/google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/it/env/Emulator.java

* Pub/Sub: default values in batch settings comments Ref: https://github.com/googleapis/gax-java/blob/master/gax/src/main/java/com/google/api/gax/batching/BatchingSettings.java * Verbose comment

…4344) * Update maven-surefire-plugin to 3.0.0-M3 to fix Java 8 classloader * Update failsafe plugin to 3.0.0-M3 too * Specify maven-surefire-plugin version in bigtable-emulator

BREAKING CHANGE: The `areTimestampsInSnapshotsEnabled()` setting is now enabled by default so timestamp fields read from a `DocumentSnapshot` will be returned as `Timestamp` objects instead of `Date`. Any code expecting to receive a `Date` object must be updated.

* Regenerate asset client * Regenerate automl client * Regenerate bigquerydatatransfer client * Regenerate bigquerystorage client * Regenerate bigtable client * Regenerate container client * Regenerate containeranalysis client * Regenerate dataproc client * Regenerate dialogflow client * Regenerate dlp client * Regenerate errorreporting client * Regenerate iamcredentials client * Regenerate iot client * Regenerate kms client * Regenerate language client * Regenerate logging client * Regenerate monitoring client * Regenerate os-login client * Regenerate pubsub client * Regenerate redis client * Regenerate securitycenter client * Regenerate speech client * Regenerate tasks client * Regenerate trace client * Regenerate video-intelligence client * Regenerate websecurityscanner client

* tableAdmin sample and tests * comments added * files renamed and other edits * some changes in TableAdminExample and tests * fixed timestamp to base 16 * separate properties for bigtable.project and bigtable.instance

This is required for v1 and accepted in v1beta1. Port of googleapis/nodejs-firestore@52c7381

* Removing some unused dependencies Also, reducing scope of auto-value to provided. * Restoring Firestore auto-value * Removing more instances of easymock.

* Removing non-deprecated uses of joda time. This works towards #3482 * Update pom.xml * Ran `mvn com.coveo:fmt-maven-plugin:format` * Fixing a bad merge

* fixing some deprecation warnings * updated comment

* Fix Location configurable from BigQueryOptions * modified code * modified code and add test case * removed unused location

* Bigtable: make row & cell ordering more consistent. * RowCells should always be ordered in lexicographically by family, then qualifier and finally by reverse chronological order * Although rows will always be ordered lexicographically by row key, they should not implement Comparable to avoid confusion when compareTo() == 0 and equals() is false. Instead that ordering was moved to a separate comparator. * Add helpers to filter cells by family & qualifier * tweaks * code style * code style

codecov · 2019-02-03T07:16:35Z

Codecov Report

Merging #4436 into spanner will increase coverage by 0.07%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             spanner    #4436      +/-   ##
=============================================
+ Coverage      49.09%   49.17%   +0.07%     
- Complexity     20607    20989     +382     
=============================================
  Files           1960     1996      +36     
  Lines         190489   194633    +4144     
  Branches       21594    21797     +203     
=============================================
+ Hits           93530    95706    +2176     
- Misses         88870    90817    +1947     
- Partials        8089     8110      +21

Impacted Files	Coverage Δ	Complexity Δ
...in/java/com/google/cloud/pubsub/v1/StatusUtil.java	`71.42% <0%> (-6.35%)`	`4% <0%> (ø)`
...cloud/pubsub/v1/StreamingSubscriberConnection.java	`70.88% <0%> (-2.15%)`	`18% <0%> (ø)`
.../main/java/com/google/cloud/compute/v1/Router.java	`31.18% <0%> (-1.6%)`	`19% <0%> (+1%)`
...ud/storage/contrib/nio/CloudStorageFileSystem.java	`64.28% <0%> (-0.53%)`	`27% <0%> (+1%)`
...ge/contrib/nio/CloudStorageFileSystemProvider.java	`63.91% <0%> (-0.41%)`	`68% <0%> (+1%)`
...3/stub/NotificationChannelServiceStubSettings.java	`78.08% <0%> (-0.13%)`	`17% <0%> (ø)`
...eta2/stub/WorkflowTemplateServiceStubSettings.java	`83.33% <0%> (-0.1%)`	`17% <0%> (ø)`
...c/main/java/com/google/cloud/logging/LogEntry.java	`90.1% <0%> (-0.01%)`	`49% <0%> (+1%)`
...ogle/cloud/dlp/v2/stub/DlpServiceStubSettings.java	`0% <0%> (ø)`	`0% <0%> (ø)`	⬇️
...oogle/cloud/container/v1/ClusterManagerClient.java	`89.32% <0%> (ø)`	`99% <0%> (ø)`	⬇️
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54a5e19...50680e9. Read the comment docs.

googlebot · 2019-02-03T07:18:08Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

snehashah16 and others added 30 commits October 31, 2018 13:49

Fix: writeAtLeastOnce should use a ReadWriteSession (#3882)

513cd25

Fix search folder for BQDT synth output (#3878)

0d6839b

Bigtable: Add integration test to test nonexistent row handling (#3870)

69133fc

Fix #3292 (#3875)

34b05af

Regenerate video-intelligence client (#3865)

77e971a

Release v0.69.0 (#3890)

78f67a2

Bump next snapshot (#3892)

9dcd23b

Bigtable: fix admin tests to able to run concurrently (#3895)

9c111f4

Fix ApiFutures.addCallback() (#3886)

7d50799

ApiFutures.addCallback() now requires a third argument (a non-direct executor). Ref: https://github.com/googleapis/api-common-java/blob/master/src/main/java/com/google/api/core/ApiFutures.java

Regenerate logging client with test fixes (#3907)

97e004f

Regenerate DLP Client (#3823)

0cafe71

Regenerate vision client: Adds product search (#3888)

cccd8d5

* Regenerate vision client * vision proto libraries need com.google.api:api-common compile dependency

Regenerate dataproc client (#3906)

e1eabce

Unsets empty list of retry status codes

Regenerate monitoring client (#3908)

753513b

Unsets empty list of no-retry status codes

Move BOM info to right after Quick Start (#3555)

269546f

* Move BOM info to right after Quick Start * split version management * change to old version combinations * Update README.md

Regenerate compute client (#3916)

6b39005

Adds interconnect features

Regenerate dlp client (#3917)

83e52cf

Add excluded_fields to BigQueryOptions

Add a feature to list the buckets (#3915)

aa93a47

Also, update the README to reflect recent update to pseudoDirs.

Update CODEOWNERS

95d4641

fallback match should be last

Logging: Add a traceSampled field to the LogEntry class. (#3863)

82c0d01

The new field was added to the Stackdriver LogEntry protocol buffer message in googleapis/googleapis@7b34e5a#diff-a51916a680df6453b6d86586cd7d63f9R149.

Bigtable: add sync methods (#3856)

68e6d1a

New Client: Cloud Scheduler (#3913)

7e63569

* Add synth.py for generating cloud scheduler client * Add generated cloud scheduler code * Fix proto/grpc artifact names * Add versions and pom.xml files * Update list of stub packages in google-cloud-clients * Add README

Exists method added in BigtableInstanceAdminClient (#3891)

327e1b6

Firestore: Validate that at least one argument is provided for Cursor (…

229ab05

…#3900)

Release google-cloud-java v0.70.0 (#3921)

8e2b7ec

Bump next snapshot (#3922)

9fdb163

anguillanneuf and others added 25 commits January 16, 2019 13:02

Pub/Sub: default values in batch settings comments (#4350)

052c4a9

* Pub/Sub: default values in batch settings comments Ref: https://github.com/googleapis/gax-java/blob/master/gax/src/main/java/com/google/api/gax/batching/BatchingSettings.java * Verbose comment

Update maven-surefire-plugin to 3.0.0-M3 to fix Java 8 classloader (#…

fe59de2

…4344) * Update maven-surefire-plugin to 3.0.0-M3 to fix Java 8 classloader * Update failsafe plugin to 3.0.0-M3 too * Specify maven-surefire-plugin version in bigtable-emulator

Bigtable: Fixing a typo for KeyOffSet#geyKey to getKey (#4342)

a696105

Regenerate spanner client (#4332)

6b5582a

Spanner: remove junit from compile dependencies (#4334)

cf7585b

Release google-cloud-java v0.78.0 (#4386)

62d4bd3

Regenerate compute client (#4359)

f62e169

Cloud Bigtable: tableAdmin sample (#4313)

2738502

* tableAdmin sample and tests * comments added * files renamed and other edits * some changes in TableAdminExample and tests * fixed timestamp to base 16 * separate properties for bigtable.project and bigtable.instance

Regenerate scheduler client (#4294)

633b982

Regenerate spanner client (#4388)

5d2626d

Bump next snapshot (#4391)

53e2bcb

Regenerate asset client (#4395)

c54f81f

Regenerate scheduler client (#4396)

c9f7d7b

Firestore: Include a trailing /documents on root resource paths (#4352)

ed7bc85

This is required for v1 and accepted in v1beta1. Port of googleapis/nodejs-firestore@52c7381

Release v0.79.0 (#4402)

82287b5

Removing some unused dependencies (#4385)

9f2b2bb

* Removing some unused dependencies Also, reducing scope of auto-value to provided. * Restoring Firestore auto-value * Removing more instances of easymock.

Removing non-deprecated uses of joda time. (#4351)

8ef362e

* Removing non-deprecated uses of joda time. This works towards #3482 * Update pom.xml * Ran `mvn com.coveo:fmt-maven-plugin:format` * Fixing a bad merge

Bump next snapshot (#4405)

8fc5f7a

fix shading (#4406)

9c47e1b

Fixing some deprecation warnings (#4390)

b92a48b

* fixing some deprecation warnings * updated comment

BigQuery : Fix Location configurable at BigQueryOptions (#4329)

f4bac2f

* Fix Location configurable from BigQueryOptions * modified code * modified code and add test case * removed unused location

Generate Firestore API v1 (#4410)

7fc4b3b

snehashah16 requested a review from a team as a code owner February 3, 2019 07:16

snehashah16 merged commit 47c840e into spanner Feb 3, 2019

googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Feb 3, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge request #4436

Merge request #4436

snehashah16 commented Feb 3, 2019

codecov bot commented Feb 3, 2019 •

edited

Loading

googlebot commented Feb 3, 2019

Merge request #4436

Merge request #4436

Conversation

snehashah16 commented Feb 3, 2019

codecov bot commented Feb 3, 2019 • edited Loading

Codecov Report

googlebot commented Feb 3, 2019

codecov bot commented Feb 3, 2019 •

edited

Loading