Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bigtable: 00. Add a couple of developer helper scripts #2841

Merged
merged 7 commits into from
Feb 5, 2018
Merged

Bigtable: 00. Add a couple of developer helper scripts #2841

merged 7 commits into from
Feb 5, 2018

Conversation

igorbernstein2
Copy link

@igorbernstein2 igorbernstein2 commented Feb 2, 2018 •
edited
Loading

This is to ease updating the gapic client and updating googleapis

This has been reviewed by Kevin, however the following changes were made since:

  • paths have been updated from the overlay to the in tree updates
  • file lists have been added to allow regeneration
  • bin was renamed to scripts
  • a readme was added

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 2, 2018
@pongad
Copy link
Contributor

pongad commented Feb 5, 2018

LGTM. @garrettjonesgoogle Do you want to take a look?

garrettjonesgoogle
garrettjonesgoogle reviewed Feb 5, 2018
View reviewed changes
google-cloud-bigtable/pom.xml Outdated
<plugins>
<plugin>
<groupId>com.theoryinpractise</groupId>
<artifactId>googleformatter-maven-plugin</artifactId>

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

google-cloud-bigtable/scripts/autogen_files.lst Outdated
@@ -0,0 +1,27 @@
src/test/java/com/google/cloud/bigtable/data/v2/MockBigtable.java

This comment was marked as spam.

Sign in to view

google-cloud-bigtable/scripts/regenerate.sh Outdated
# It is meant to be used to test changes to the gapic config before publishing
# To pull in upstream changes, please use update-deps.sh

set -eE # same as: `set -o errexit -o errtrace`

This comment was marked as spam.

Sign in to view

google-cloud-bigtable/scripts/regenerate.sh
@@ -0,0 +1,134 @@
#!/usr/bin/env bash

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

google-cloud-bigtable/scripts/update-deps.sh
git -C "$DIR" fetch origin >>$LOG 2>&1

log "Dropping uncommitted local changes"
git -C "$DIR" reset --hard HEAD >>$LOG 2>&1

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@igorbernstein2
Copy link
Author

Responded to all feedback. PTAL

garrettjonesgoogle
garrettjonesgoogle reviewed Feb 5, 2018
View reviewed changes
Copy link
Member

@garrettjonesgoogle garrettjonesgoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igorbernstein2
Copy link
Author

Created an issue:
#2852

Please merge when ready

@pongad pongad merged commit 6855f84 into googleapis:master Feb 5, 2018
@igorbernstein2 igorbernstein2 deleted the 00-dev-scripts branch February 20, 2018 17:06
@igorbernstein2 igorbernstein2 mentioned this pull request Feb 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garrettjonesgoogle garrettjonesgoogle garrettjonesgoogle left review comments

@pongad pongad Awaiting requested review from pongad

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@igorbernstein2 @pongad @garrettjonesgoogle @googlebot