Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize Bigtable's regenerate scripts to applicable to other clients #2852

Closed
igorbernstein2 opened this issue Feb 5, 2018 · 3 comments
Closed
Assignees
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@igorbernstein2
Copy link

The new Bigtable client has 2 scripts to help test GAPIC config changes. The scripts allow the developer to make a change in a local googleapis checkout and see how the changes will look in api-client-staging and google-cloud-java. It would be nice to open these scripts to other clients.

Also, the update script is currently pretty careless about overwriting local changes, this will need to narrowed down to autogenerated files to avoid destroying local changes

@igorbernstein2 igorbernstein2 self-assigned this Feb 5, 2018
@pongad pongad added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Feb 6, 2018
@igorbernstein2
Copy link
Author

This came out of discussion in #2841. I was planning on generalizing the scripts once the bigtable client stabilizes. Should I not be planning to do this?

@yihanzhen
Copy link
Contributor

Sorry I thought this issue was used to track the merged PR.

@yihanzhen yihanzhen reopened this Feb 20, 2018
@yihanzhen yihanzhen reopened this Feb 21, 2018
@JustinBeckwith JustinBeckwith added the 🚨 This issue needs some love. label Aug 4, 2018
@sduskis sduskis removed 🚨 This issue needs some love. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Oct 9, 2018
@chingor13
Copy link
Contributor

There is now the utilities/batch_generate_apis.py script and yoshi-team is using synthtool to regenerate clients in #3765.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

6 participants