Make storage.update use normal update and add storage.patch #276

mziccard · 2015-10-21T16:17:48Z

This PR follows the discussion in #60.
This PR changes to storage.update method to use normal update rather than patch. It also adds a storage.patch method. Main changes are:

Add update method to StoragRpc
Make Storage.update use StorageRpc.update instead of patch
Add Storage.patch(blobInfo) method
Add support for patches to BatchRequest
Add static Storage.patch(BlobInfo...) method for easily batching patches
Add Blob.patch(blobInfo) and static Blob.patch(blobInfo...) to reflect storage changes
Add and update unit/integration tests
Update javadoc to document update/patch behavior

Sorry for the big and scattered PR, comments are welcome.

- Add update method to StoragRpc - Make Storage.update use StorageRpc.update instead of patch - Add Storage.patch(blobInfo) method - Add support for patches to BatchRequest (both Storage and StorageRpc) - Add static Storage.patch(BlobInfo...) method for easily batching patches - Update and add new tests - Update and add javadoc for Storage.update and Storage.patch

gcloud-java-storage/src/main/java/com/google/gcloud/spi/DefaultStorageRpc.java

@@ -418,11 +441,26 @@ public void onFailure(GoogleJsonError e, HttpHeaders responseHeaders) {
          }
        });
      }
+      for (final Tuple<StorageObject, Map<Option, ?>> tuple : request.toPatch) {


aozarov · 2015-10-23T18:21:01Z

We can close this one, right?

mziccard · 2015-10-23T18:27:32Z

Yes we don't need this anymore!

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 456641589 Source-Link: googleapis/googleapis@8a251f5 Source-Link: https://github.com/googleapis/googleapis-gen/commit/4ca52a529cf01308d9714950edffbea3560cfbdb Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGNhNTJhNTI5Y2YwMTMwOGQ5NzE0OTUwZWRmZmJlYTM1NjBjZmJkYiJ9

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/18040a8c-dd59-4849-a8e5-91f73765acf9/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@5a506ec

🤖 I have created a release \*beep\* \*boop\* --- ### [1.0.1](https://www.github.com/googleapis/java-workflows/compare/v1.0.0...v1.0.1) (2021-06-09) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v1.3.0 ([#274](https://www.github.com/googleapis/java-workflows/issues/274)) ([fa83b51](https://www.github.com/googleapis/java-workflows/commit/fa83b51413dd911f4bced55e68c084517f5a5981)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Making CLIRR not required. The version bumps are now controlled by the Release Please and OwlBot. The CL authors create appropriate change description to control major version bumps.

🤖 I have created a release *beep* *boop* --- ## [2.3.0](googleapis/java-profiler@v2.2.0...v2.3.0) (2022-07-01) ### Features * Enable REST transport for most of Java and Go clients ([googleapis#276](googleapis/java-profiler#276)) ([ce386fe](googleapis/java-profiler@ce386fe)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([googleapis#275](googleapis/java-profiler#275)) ([cdb1e0e](googleapis/java-profiler@cdb1e0e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ## [2.3.1](googleapis/java-api-gateway@v2.3.0...v2.3.1) (2022-07-13) ### Bug Fixes * enable longpaths support for windows test ([#1485](https://github.com/googleapis/java-api-gateway/issues/1485)) ([#275](googleapis/java-api-gateway#275)) ([83c69c2](googleapis/java-api-gateway@83c69c2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…ator_java versions (#276) - [ ] Regenerate this pull request now. PiperOrigin-RevId: 472750037 Source-Link: googleapis/googleapis@88f2ea3 Source-Link: https://github.com/googleapis/googleapis-gen/commit/230a5588306aae18fe8f2a57f14d4039ad72c901 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjMwYTU1ODgzMDZhYWUxOGZlOGYyYTU3ZjE0ZDQwMzlhZDcyYzkwMSJ9

…1575) (#276) Source-Link: googleapis/synthtool@2e9ac19 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93

🤖 I have created a release *beep* *boop* --- ## [2.2.6](googleapis/java-dms@v2.2.5...v2.2.6) (2022-09-29) ### Dependencies * Update dependency cachetools to v5 ([#288](googleapis/java-dms#288)) ([9370173](googleapis/java-dms@9370173)) * Update dependency certifi to v2022.9.24 ([#268](googleapis/java-dms#268)) ([1745004](googleapis/java-dms@1745004)) * Update dependency charset-normalizer to v2.1.1 ([#272](googleapis/java-dms#272)) ([367ffd9](googleapis/java-dms@367ffd9)) * Update dependency click to v8.1.3 ([#273](googleapis/java-dms#273)) ([328f00b](googleapis/java-dms@328f00b)) * Update dependency gcp-releasetool to v1.8.8 ([#269](googleapis/java-dms#269)) ([7d68646](googleapis/java-dms@7d68646)) * Update dependency google-api-core to v2.10.1 ([#274](googleapis/java-dms#274)) ([03bc3c5](googleapis/java-dms@03bc3c5)) * Update dependency google-auth to v2.12.0 ([#275](googleapis/java-dms#275)) ([bd96264](googleapis/java-dms@bd96264)) * Update dependency google-cloud-core to v2.3.2 ([#270](googleapis/java-dms#270)) ([fcd6bbd](googleapis/java-dms@fcd6bbd)) * Update dependency google-cloud-storage to v2.5.0 ([#276](googleapis/java-dms#276)) ([80b39f1](googleapis/java-dms@80b39f1)) * Update dependency google-crc32c to v1.5.0 ([#277](googleapis/java-dms#277)) ([a561425](googleapis/java-dms@a561425)) * Update dependency googleapis-common-protos to v1.56.4 ([#271](googleapis/java-dms#271)) ([296d07c](googleapis/java-dms@296d07c)) * Update dependency importlib-metadata to v4.12.0 ([#278](googleapis/java-dms#278)) ([b4509fa](googleapis/java-dms@b4509fa)) * Update dependency jeepney to v0.8.0 ([#279](googleapis/java-dms#279)) ([b2b6e8f](googleapis/java-dms@b2b6e8f)) * Update dependency jinja2 to v3.1.2 ([#280](googleapis/java-dms#280)) ([c7c2a10](googleapis/java-dms@c7c2a10)) * Update dependency keyring to v23.9.3 ([#281](googleapis/java-dms#281)) ([981c58c](googleapis/java-dms@981c58c)) * Update dependency markupsafe to v2.1.1 ([#282](googleapis/java-dms#282)) ([5a78aa3](googleapis/java-dms@5a78aa3)) * Update dependency protobuf to v3.20.2 ([#283](googleapis/java-dms#283)) ([2444bcd](googleapis/java-dms@2444bcd)) * Update dependency protobuf to v4 ([#289](googleapis/java-dms#289)) ([b9e330a](googleapis/java-dms@b9e330a)) * Update dependency pyjwt to v2.5.0 ([#284](googleapis/java-dms#284)) ([9fc617d](googleapis/java-dms@9fc617d)) * Update dependency requests to v2.28.1 ([#285](googleapis/java-dms#285)) ([51574b4](googleapis/java-dms@51574b4)) * Update dependency typing-extensions to v4.3.0 ([#286](googleapis/java-dms#286)) ([c36d416](googleapis/java-dms@c36d416)) * Update dependency zipp to v3.8.1 ([#287](googleapis/java-dms#287)) ([34e4986](googleapis/java-dms@34e4986)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ## [2.3.5](https://togithub.com/googleapis/java-gsuite-addons/compare/v2.3.4...v2.3.5) (2022-10-03) ### Dependencies * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#275](https://togithub.com/googleapis/java-gsuite-addons/issues/275)) ([974dd0f](https://togithub.com/googleapis/java-gsuite-addons/commit/974dd0fee0ac691e6b68c251c7707a3b8f09ee6a)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

…l-contacts to v2.3.6 (#276) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-essential-contacts](https://togithub.com/googleapis/java-essential-contacts) | `2.3.5` -> `2.3.6` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-essential-contacts/2.3.6/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-essential-contacts/2.3.6/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-essential-contacts/2.3.6/compatibility-slim/2.3.5)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-essential-contacts/2.3.6/confidence-slim/2.3.5)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-essential-contacts).

mziccard added 2 commits October 21, 2015 16:23

Add patch (static and non) method to Blob, add tests

f2a6878

mziccard added the api: storage Issues related to the Cloud Storage API. label Oct 21, 2015

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 21, 2015

aozarov reviewed Oct 21, 2015
View reviewed changes

aozarov mentioned this pull request Oct 22, 2015

The result of a patch metadata is a union rather than replacement. #60

Closed

mziccard mentioned this pull request Oct 22, 2015

Provide a way to unset blob metadata #279

Merged

mziccard added 2 commits October 22, 2015 14:50

Move patch requests ahead of gets in batch

c80f5a0

Fix error in BatchResponse.equals

96702f8

mziccard closed this Oct 23, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make storage.update use normal update and add storage.patch #276

Make storage.update use normal update and add storage.patch #276

mziccard commented Oct 21, 2015

This comment was marked as spam.

aozarov commented Oct 23, 2015

mziccard commented Oct 23, 2015

Make storage.update use normal update and add storage.patch #276

Make storage.update use normal update and add storage.patch #276

Conversation

mziccard commented Oct 21, 2015

This comment was marked as spam.

aozarov commented Oct 23, 2015

mziccard commented Oct 23, 2015