Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File system close declares it throws IOException #1060

Merged
merged 1 commit into from
Jun 20, 2016
Merged

File system close declares it throws IOException #1060

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ...d-java-nio/src/main/java/com/google/cloud/storage/contrib/nio/CloudStorageFileSystem.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,10 +145,12 @@ public CloudStoragePath getPath(String first, String... more) {
* Does nothing.
*/
@Override
public void close() {}
public void close() throws IOException {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

// TODO(#809): Synchronously close all channels associated with this FileSystem instance.
}

/**
* Returns {@code true}.
* Returns {@code true}, even if you previously called the {@link #close()} method.
*/
@Override
public boolean isOpen() {
Expand Down
4 changes: 2 additions & 2 deletions ...rc/test/java/com/google/cloud/storage/contrib/nio/CloudStorageFileSystemProviderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@ public void testExists_trailingSlash() {
}

@Test
public void testExists_trailingSlash_disablePseudoDirectories() {
public void testExists_trailingSlash_disablePseudoDirectories() throws IOException {
try (CloudStorageFileSystem fs = forBucket("military", usePseudoDirectories(false))) {
assertThat(Files.exists(fs.getPath("fashion/"))).isFalse();
}
Expand Down Expand Up @@ -547,7 +547,7 @@ public void testIsDirectory_trailingSlash_alwaysTrue() {
}

@Test
public void testIsDirectory_trailingSlash_pseudoDirectoriesDisabled_false() {
public void testIsDirectory_trailingSlash_pseudoDirectoriesDisabled_false() throws IOException {
try (CloudStorageFileSystem fs = forBucket("doodle", usePseudoDirectories(false))) {
assertThat(Files.isDirectory(fs.getPath("fundir/"))).isFalse();
}
Expand Down
Loading