File system close declares it throws IOException #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in case we decide to implement "close all owned channels"
googlebot
added
the
cla: yes
| @@ -145,10 +145,12 @@ public CloudStoragePath getPath(String first, String... more) { | |||
| * Does nothing. | |||
| */ | |||
| @Override | |||
| public void close() {} | |||
| public void close() throws IOException { | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
See my comment on implementing the method rather than putting a TODO. Otherwise LGTM. |
mziccard
pushed a commit
to mziccard/gcloud-java
that referenced
this pull request
Jun 29, 2016
mziccard
pushed a commit
to mziccard/gcloud-java
that referenced
this pull request
Jun 30, 2016
github-actions bot
pushed a commit
that referenced
this pull request
Sep 19, 2022
🤖 I have created a release *beep* *boop* --- ## [2.3.4](googleapis/java-translate@v2.3.3...v2.3.4) (2022-09-15) ### Dependencies * Update dependency com.google.cloud:google-cloud-core to v2.8.10 ([#1069](googleapis/java-translate#1069)) ([2bee3ba](googleapis/java-translate@2bee3ba)) * Update dependency com.google.cloud:google-cloud-core to v2.8.11 ([#1073](googleapis/java-translate#1073)) ([8a869f6](googleapis/java-translate@8a869f6)) * Update dependency com.google.cloud:google-cloud-core to v2.8.9 ([#1066](googleapis/java-translate#1066)) ([69d391c](googleapis/java-translate@69d391c)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#1074](googleapis/java-translate#1074)) ([c8bfd65](googleapis/java-translate@c8bfd65)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 ([#1077](googleapis/java-translate#1077)) ([aa9ef02](googleapis/java-translate@aa9ef02)) * Update dependency com.google.cloud:google-cloud-storage to v2.11.3 ([#1060](googleapis/java-translate#1060)) ([4d9a7ad](googleapis/java-translate@4d9a7ad)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
suztomo
pushed a commit
that referenced
this pull request
Feb 1, 2023
….6.23 (#1060) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.api.grpc:proto-google-iam-v1](https://togithub.com/googleapis/java-iam/proto-google-iam-v1) ([source](https://togithub.com/googleapis/java-iam)) | `1.6.22` -> `1.6.23` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-iam</summary> ### [`v1.6.23`](https://togithub.com/googleapis/java-iam/blob/HEAD/CHANGELOG.md#​1623-httpsgithubcomgoogleapisjava-iamcomparev1622v1623-2022-12-20) [Compare Source](https://togithub.com/googleapis/java-iam/compare/v1.6.22...v1.6.23) ##### Dependencies - Update dependency com.google.api:api-common to v2.3.1 ([#​567](https://togithub.com/googleapis/java-iam/issues/567)) ([17e62e8](https://togithub.com/googleapis/java-iam/commit/17e62e80f0ea8c2d4edfe6bb16ef5ee7acbc22f3)) - Update dependency com.google.auth:google-auth-library-oauth2-http to v1.14.0 ([#​571](https://togithub.com/googleapis/java-iam/issues/571)) ([9c48311](https://togithub.com/googleapis/java-iam/commit/9c48311fbac25f9c9545f3404a42cdadf8ebb243)) - Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.1.0 ([#​565](https://togithub.com/googleapis/java-iam/issues/565)) ([32be2fb](https://togithub.com/googleapis/java-iam/commit/32be2fb0cfafa3681489c18e367cf12f22c567d3)) - Update dependency com.google.cloud:google-iam-policy to v1.6.22 ([#​560](https://togithub.com/googleapis/java-iam/issues/560)) ([de39d89](https://togithub.com/googleapis/java-iam/commit/de39d89c08c9e45bc977ea393570a8d01cf48af2)) - Update dependency com.google.protobuf:protobuf-bom to v3.21.12 ([#​563](https://togithub.com/googleapis/java-iam/issues/563)) ([607e260](https://togithub.com/googleapis/java-iam/commit/607e2601b71ff1fb51406e6c97dd79208296f404)) - Update dependency com.google.protobuf:protobuf-java to v3.21.12 ([#​564](https://togithub.com/googleapis/java-iam/issues/564)) ([4b2b26b](https://togithub.com/googleapis/java-iam/commit/4b2b26bd29d88ccb602a71225d6e2decb49b9649)) - Update dependency io.grpc:grpc-protobuf to v1.51.1 ([#​573](https://togithub.com/googleapis/java-iam/issues/573)) ([2143ec8](https://togithub.com/googleapis/java-iam/commit/2143ec8a90dbcdb128dffea9777fa9d183c3068e)) - Update dependency io.grpc:grpc-stub to v1.51.1 ([#​574](https://togithub.com/googleapis/java-iam/issues/574)) ([488496a](https://togithub.com/googleapis/java-iam/commit/488496aa09c9d976bf0c450fb8584f07e7c74c03)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-core). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4yNC4wIiwidXBkYXRlZEluVmVyIjoiMzQuMjQuMCJ9-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in case we decide to implement "close all owned channels" (issue #809)
cc:mziccard