-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DatasetInfo could use a static of() method #1266
Comments
Yes, totally, I'll add it. |
github-actions bot
pushed a commit
to suztomo/google-cloud-java
that referenced
this issue
Jun 29, 2022
github-actions bot
pushed a commit
to suztomo/google-cloud-java
that referenced
this issue
Jun 29, 2022
🤖 I have created a release \*beep\* \*boop\* --- ## [1.2.0](https://www.github.com/googleapis/java-resourcemanager/compare/v1.1.4...v1.2.0) (2021-12-03) ### Features * next release from main branch is 1.2.0 ([googleapis#659](https://www.github.com/googleapis/java-resourcemanager/issues/659)) ([8af7d6d](https://www.github.com/googleapis/java-resourcemanager/commit/8af7d6de5eb05cf3c08c52e13e4ef47a51fb7d36)) ### Bug Fixes * **java:** java 17 dependency arguments ([googleapis#1266](https://www.github.com/googleapis/java-resourcemanager/issues/1266)) ([googleapis#656](https://www.github.com/googleapis/java-resourcemanager/issues/656)) ([2bb306a](https://www.github.com/googleapis/java-resourcemanager/commit/2bb306a23319c415666f72ff8f793385c5a7a3f0)) ### Documentation * fix docstring formatting ([googleapis#665](https://www.github.com/googleapis/java-resourcemanager/issues/665)) ([cb79f5f](https://www.github.com/googleapis/java-resourcemanager/commit/cb79f5f49b2d3941c698c11c2e0177e89a44e153)) * fix docstring formatting ([googleapis#673](https://www.github.com/googleapis/java-resourcemanager/issues/673)) ([5e371b9](https://www.github.com/googleapis/java-resourcemanager/commit/5e371b93873b361e5d9b54a29c50bc91d63e39b3)) ### Dependencies * update dependency com.google.apis:google-api-services-cloudresourcemanager to v1-rev20211017-1.32.1 ([googleapis#654](https://www.github.com/googleapis/java-resourcemanager/issues/654)) ([d489a3e](https://www.github.com/googleapis/java-resourcemanager/commit/d489a3e486113d75caa419e5fe0ab182764f7b49)) * update dependency com.google.apis:google-api-services-cloudresourcemanager to v1-rev20211107-1.32.1 ([googleapis#670](https://www.github.com/googleapis/java-resourcemanager/issues/670)) ([c648624](https://www.github.com/googleapis/java-resourcemanager/commit/c648624456d10518971d3a8ad2ef897a8f520576)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.5.0 ([googleapis#672](https://www.github.com/googleapis/java-resourcemanager/issues/672)) ([c07eaef](https://www.github.com/googleapis/java-resourcemanager/commit/c07eaef86911a560e51b85b726d26c1f82e9cbf1)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.5.1 ([googleapis#678](https://www.github.com/googleapis/java-resourcemanager/issues/678)) ([3bfbff5](https://www.github.com/googleapis/java-resourcemanager/commit/3bfbff573edbf1e11472f8eba130470a0c9d7841)) * update dependency com.google.errorprone:error_prone_annotations to v2.10.0 ([googleapis#663](https://www.github.com/googleapis/java-resourcemanager/issues/663)) ([ed01782](https://www.github.com/googleapis/java-resourcemanager/commit/ed0178221930b4c3796d993e467c2481170ec863)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot
pushed a commit
that referenced
this issue
Jul 14, 2022
🤖 I have created a release *beep* *boop* --- ## [3.4.2](googleapis/java-asset@v3.4.1...v3.4.2) (2022-07-13) ### Bug Fixes * enable longpaths support for windows test ([#1485](https://github.com/googleapis/java-asset/issues/1485)) ([#1265](googleapis/java-asset#1265)) ([10841e8](googleapis/java-asset@10841e8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What:
Add a static
of()
method toDatasetInfo
, likeJobInfo
andTableId
have.Why:
It looks nicer than explicitly constructing a builder and then calling
build()
on it. See sample I wrote forcreate(DatasetInfo)
and how it could be simplified a bit.The text was updated successfully, but these errors were encountered: