Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not obvious what *Options do in create() methods #1265

Closed
bjwatson opened this issue Sep 17, 2016 · 8 comments
Closed

Not obvious what *Options do in create() methods #1265

bjwatson opened this issue Sep 17, 2016 · 8 comments
Assignees
Labels
api: core priority: p2 Moderately-important priority. Fix may not be included in next release. triaged for GA type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@bjwatson
Copy link

What:

Add documentation to create() methods, explaining that the *Options filter the fields in the results. They do not affect the creation itself.

Why:

It took me more than an hour to figure this out.

@mziccard
Copy link
Contributor

Sorry to hear you had to waste your time.

Isn't the javadoc added to all *Options classes enough to explain what they'll do when passed to create methods? See for instance DatasetOption javadoc, TableOption javadoc and JobOption.

@bjwatson
Copy link
Author

If something like the fields description is also stated in the summary for these classes, they I believe that would be sufficient. I did look at these class summaries on Friday, but did not see the more detailed and helpful description under fields.

@lesv
Copy link
Contributor

lesv commented Feb 24, 2017

@bjwatson Once you looked at the Fields descriptions, was that enough? (ie. can we close this?)

@bjwatson
Copy link
Author

My context is stale on this now, but I think what would help is to move/copy the detailed explanation from DatasetOptions.fields to the top-level description of DatasetOptions.

The current description, Class for specifying dataset get, create and update options. is not all that helpful. TableOption and JobOption have a similar issue.

@lesv
Copy link
Contributor

lesv commented Feb 28, 2017

Got it, not sure there's an automated way to do that, but:

ACCESS 
CREATION_TIME 
DATASET_REFERENCE 
DEFAULT_TABLE_EXPIRATION_MS 
DESCRIPTION 
ETAG 
FRIENDLY_NAME 
ID 
LAST_MODIFIED_TIME 
LOCATION 
SELF_LINK 

And some commentary.

@tcoffee-google tcoffee-google added the priority: p2 Moderately-important priority. Fix may not be included in next release. label Jun 12, 2017
@danoscarmike
Copy link
Contributor

@lesv @bjwatson any action remaining to be taken here?

@bjwatson
Copy link
Author

bjwatson commented Aug 9, 2017

@anthmgoogle anthmgoogle added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Nov 9, 2017
@yihanzhen
Copy link
Contributor

The feature request is added to the backlog. The issue will be closed but is linked in the backlog and can continue to be used for comment and discussion.

github-actions bot pushed a commit that referenced this issue Jul 14, 2022
Source-Link: googleapis/synthtool@7336562
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:d4b80feffe1579818cdc39466152e9de95789a193408506cd4a1ffbe8804dc00
github-actions bot pushed a commit that referenced this issue Jul 14, 2022
🤖 I have created a release *beep* *boop*
---


## [3.4.2](googleapis/java-asset@v3.4.1...v3.4.2) (2022-07-13)


### Bug Fixes

* enable longpaths support for windows test ([#1485](https://github.com/googleapis/java-asset/issues/1485)) ([#1265](googleapis/java-asset#1265)) ([10841e8](googleapis/java-asset@10841e8))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit that referenced this issue Oct 5, 2022
🤖 I have created a release *beep* *boop*
---


## [2.3.16](https://togithub.com/googleapis/java-automl/compare/v2.3.15...v2.3.16) (2022-10-04)


### Documentation

* [owlbot-java] samples do not need deploy plugin and deps upgrade ([#1583](https://togithub.com/googleapis/java-automl/issues/1583)) ([#1265](https://togithub.com/googleapis/java-automl/issues/1265)) ([4bc9752](https://togithub.com/googleapis/java-automl/commit/4bc97525d4a163033d7e715ae25a3d012d167aa6))


### Dependencies

* Update dependency com.google.cloud:google-cloud-core to v2.8.17 ([#1272](https://togithub.com/googleapis/java-automl/issues/1272)) ([b7d6234](https://togithub.com/googleapis/java-automl/commit/b7d6234ce41e80fe1775660873640768ac355c95))
* Update dependency com.google.cloud:google-cloud-core to v2.8.18 ([#1274](https://togithub.com/googleapis/java-automl/issues/1274)) ([2eb4b99](https://togithub.com/googleapis/java-automl/commit/2eb4b99133e18b2af14a9161527b47e6d3b847ae))
* Update dependency com.google.cloud:google-cloud-core to v2.8.19 ([#1276](https://togithub.com/googleapis/java-automl/issues/1276)) ([992601c](https://togithub.com/googleapis/java-automl/commit/992601c33a887edb393e3ae4b705efab349cde8d))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#1278](https://togithub.com/googleapis/java-automl/issues/1278)) ([a83e1f7](https://togithub.com/googleapis/java-automl/commit/a83e1f7c1a3a92de6f4db6edd422f9f2c2e53174))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: core priority: p2 Moderately-important priority. Fix may not be included in next release. triaged for GA type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

9 participants