Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove all uses of github.com/golang/protobuf #9744

Merged
merged 16 commits into from
Apr 15, 2024
Merged

chore: remove all uses of github.com/golang/protobuf #9744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
5c6966b
chore: remove all uses of github.com/golang/protobuf
codyoss Apr 10, 2024
7226b03
Merge branch 'main' of github.com:googleapis/google-cloud-go into to-…
codyoss Apr 10, 2024
489cabf
remove toolchain
codyoss Apr 10, 2024
65cc0d7
go mod tidy
codyoss Apr 10, 2024
bb83480
be safer
codyoss Apr 10, 2024
a1fb564
some pubsub changes
codyoss Apr 11, 2024
c740645
Merge branch 'main' of github.com:googleapis/google-cloud-go into to-…
codyoss Apr 11, 2024
8102304
fixup pubsub
codyoss Apr 11, 2024
b816efa
Merge branch 'main' of github.com:googleapis/google-cloud-go into to-…
codyoss Apr 11, 2024
548ea16
fixup rpcreplay and goimports things
codyoss Apr 11, 2024
3f99003
run goimports
codyoss Apr 11, 2024
bed6a48
Merge branch 'main' into to-new-proto-2
codyoss Apr 11, 2024
6ac017a
feedback
codyoss Apr 11, 2024
d567854
test fixes
codyoss Apr 15, 2024
95119a3
Merge branch 'main' into to-new-proto-2
codyoss Apr 15, 2024
67f689f
fixup somethings
codyoss Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions bigtable/admin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -705,12 +705,12 @@ func newSnapshotInfo(snapshot *btapb.Snapshot) (*SnapshotInfo, error) {
if err := snapshot.CreateTime.CheckValid(); err != nil {
return nil, fmt.Errorf("invalid createTime: %w", err)
}
createTime := snapshot.CreateTime.AsTime()
createTime := snapshot.GetCreateTime().AsTime()

if err := snapshot.DeleteTime.CheckValid(); err != nil {
return nil, fmt.Errorf("invalid deleteTime: %v", err)
}
deleteTime := snapshot.DeleteTime.AsTime()
deleteTime := snapshot.GetDeleteTime().AsTime()

return &SnapshotInfo{
Name: name,
Expand Down Expand Up @@ -2057,17 +2057,17 @@ func newBackupInfo(backup *btapb.Backup) (*BackupInfo, error) {
if err := backup.StartTime.CheckValid(); err != nil {
return nil, fmt.Errorf("invalid startTime: %v", err)
}
startTime := backup.StartTime.AsTime()
startTime := backup.GetStartTime().AsTime()

if err := backup.EndTime.CheckValid(); err != nil {
return nil, fmt.Errorf("invalid endTime: %v", err)
}
endTime := backup.EndTime.AsTime()
endTime := backup.GetEndTime().AsTime()

if err := backup.ExpireTime.CheckValid(); err != nil {
return nil, fmt.Errorf("invalid expireTime: %v", err)
}
expireTime := backup.ExpireTime.AsTime()
expireTime := backup.GetExpireTime().AsTime()
encryptionInfo := newEncryptionInfo(backup.EncryptionInfo)
bi := BackupInfo{
Name: name,
Expand Down
2 changes: 1 addition & 1 deletion cloudbuild/apiv1/cloud_build_client.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion cloudbuild/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ go 1.19
require (
cloud.google.com/go/iam v1.1.7
cloud.google.com/go/longrunning v0.5.6
github.com/golang/protobuf v1.5.4
github.com/googleapis/gax-go/v2 v2.12.3
google.golang.org/api v0.172.0
google.golang.org/genproto v0.0.0-20240213162025-012b6fc9bca9
Expand All @@ -22,6 +21,7 @@ require (
github.com/go-logr/logr v1.4.1 // indirect
github.com/go-logr/stdr v1.2.2 // indirect
github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da // indirect
github.com/golang/protobuf v1.5.4 // indirect
github.com/google/s2a-go v0.1.7 // indirect
github.com/googleapis/enterprise-certificate-proxy v0.3.2 // indirect
go.opencensus.io v0.24.0 // indirect
Expand Down
2 changes: 1 addition & 1 deletion datastore/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ go 1.19
require (
cloud.google.com/go v0.112.2
cloud.google.com/go/longrunning v0.5.6
github.com/golang/protobuf v1.5.4
github.com/google/go-cmp v0.6.0
github.com/googleapis/gax-go/v2 v2.12.3
google.golang.org/api v0.172.0
Expand All @@ -22,6 +21,7 @@ require (
github.com/go-logr/logr v1.4.1 // indirect
github.com/go-logr/stdr v1.2.2 // indirect
github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da // indirect
github.com/golang/protobuf v1.5.4 // indirect
github.com/google/s2a-go v0.1.7 // indirect
github.com/googleapis/enterprise-certificate-proxy v0.3.2 // indirect
go.opencensus.io v0.24.0 // indirect
Expand Down
Loading
Loading