Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove all uses of github.com/golang/protobuf #9744

Merged
merged 16 commits into from
Apr 15, 2024
Merged

chore: remove all uses of github.com/golang/protobuf #9744

merged 16 commits into from
Apr 15, 2024

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Apr 10, 2024

Fixes: #4273

@codyoss codyoss marked this pull request as ready for review April 11, 2024 20:15
@codyoss codyoss requested review from a team and shollyman as code owners April 11, 2024 20:15
@codyoss codyoss requested a review from gkevinzheng April 11, 2024 20:15
noahdietz
noahdietz reviewed Apr 11, 2024
View reviewed changes
firestore/client.go Outdated Show resolved Hide resolved
firestore/conformance_test.go Outdated Show resolved Hide resolved
firestore/options.go Show resolved Hide resolved
internal/gapicgen/go.mod Show resolved Hide resolved
internal/postprocessor/go.mod Show resolved Hide resolved
logging/logadmin/logadmin.go Outdated Show resolved Hide resolved
longrunning/longrunning.go Outdated Show resolved Hide resolved
pubsub/loadtest/pb/loadtest.proto Outdated Show resolved Hide resolved
pubsublite/config.go Show resolved Hide resolved
noahdietz
noahdietz approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@noahdietz noahdietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super dope! Love to see it. LGTM generally, will let specifically requested codeowners review.

@noahdietz
Copy link
Contributor

Ooh what do you want to do about the pubsub/loadtest proto breaking changes? The package docs indicate it is experimental, but I think we could use some stronger language if this is an internal implementation package...or even a move to an internal dir...

hongalex
hongalex approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@hongalex hongalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Cody! Verified that the Pub/Sub portions are still functioning as before

@hongalex
Copy link
Member

Ooh what do you want to do about the pubsub/loadtest proto breaking changes? The package docs indicate it is experimental, but I think we could use some stronger language if this is an internal implementation package...or even a move to an internal dir...

The proto breaking was a result of the source proto change. I'm not really opposed to moving it to internal though.

@bhshkh
Copy link
Contributor

bhshkh commented Apr 12, 2024

The Bigtable conformance test failures can be ignored. The tests were enabled in failed state.

@codyoss
Copy link
Member Author

codyoss commented Apr 15, 2024

proceeding with this change should CI pass

@codyoss codyoss added the automerge Merge the pull request once unit tests and other checks pass. label Apr 15, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit c188071 into googleapis:main Apr 15, 2024
38 of 43 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 15, 2024
@sg0hsmt sg0hsmt mentioned this pull request May 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hongalex hongalex hongalex approved these changes

@noahdietz noahdietz noahdietz approved these changes

@tritone tritone tritone approved these changes

@shollyman shollyman Awaiting requested review from shollyman shollyman is a code owner

@gkevinzheng gkevinzheng Awaiting requested review from gkevinzheng gkevinzheng is a code owner automatically assigned from googleapis/api-logging

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

all: switch to google.golang.org/protobuf
5 participants
@codyoss @noahdietz @hongalex @bhshkh @tritone