Allow client to set Accept-Encoding header in object request #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ernsheong
commented
Oct 21, 2017
storage/storage.go
Outdated
| userProject string // for requester-pays buckets | ||
| encryptionKey []byte // AES-256 key | ||
| userProject string // for requester-pays buckets | ||
| reqHeaders map[string][]string // to set custom request headers e.g. "Accept-Encoding" |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Oops, looks like Github PRs are not valid. |
gcf-owl-bot bot
added a commit
that referenced
this pull request
Apr 10, 2023
Followup to #794 now that the Go generator has been patched Source-Link: googleapis/googleapis@2954139 Source-Link: googleapis/googleapis-gen@bcb74f7 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYmNiNzRmNzNlZjk0NGU4MWMyNDNlNDNmZTJhMmE2YmNiMjA0ZTJhMiJ9
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Apr 10, 2023
- [ ] Regenerate this pull request now. Followup to #794 now that the Go generator has been patched Source-Link: https://togithub.com/googleapis/googleapis/commit/2954139219b05e346f3d046a1e691214b7d9f7de Source-Link: https://togithub.com/googleapis/googleapis-gen/commit/bcb74f73ef944e81c243e43fe2a2a6bcb204e2a2 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYmNiNzRmNzNlZjk0NGU4MWMyNDNlNDNmZTJhMmE2YmNiMjA0ZTJhMiJ9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My quick stab for the enhancement in #449
Apologies if this is not quite the way to do it. I don't have much Golang production experience, or experience with code practices in google-cloud-go. Happy to get feedback!
Let me know how it can be improved, and if this would require a unit test!