Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datastore client deadlocks on GetMulti call #794

Closed
ghost opened this issue Oct 20, 2017 · 2 comments
Closed

Datastore client deadlocks on GetMulti call #794

ghost opened this issue Oct 20, 2017 · 2 comments
Assignees
Labels
api: datastore Issues related to the Datastore API.

Comments

@ghost
Copy link

ghost commented Oct 20, 2017

With the latest version of the grpc-go library, client.GetMulti blocks forever.

Digging deeper, https://github.com/grpc/grpc-go/blob/master/clientconn.go#L800 is where it's blocking at. Seems like it's an issue with the grpc library, filing it here since it has an impact on Google Cloud products.

Rolling back the grpc-go library resolves this issue.

@ghost
Copy link
Author

ghost commented Oct 20, 2017

More info along with a small repro at: grpc/grpc-go#1605

@jba jba self-assigned this Oct 20, 2017
@jba jba added the api: datastore Issues related to the Datastore API. label Oct 20, 2017
@ghost
Copy link
Author

ghost commented Oct 21, 2017

grpc/grpc-go#1606 has fixed this issue. This is good to close.

@ghost ghost closed this as completed Oct 21, 2017
gcf-owl-bot bot added a commit that referenced this issue Apr 6, 2023
Source-Link: googleapis/googleapis@cc293c6

Source-Link: googleapis/googleapis-gen@6bb5382
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNmJiNTM4MmFiM2NkMzIyY2MxMjI4ZWI1ODdhZGI1ZTEyMzVjNWJkMyJ9
gcf-owl-bot bot added a commit that referenced this issue Apr 10, 2023
feat: support per-entity search and autocomplete
feat: support new filter syntax for recommendation
feat: expose A/B experiment info in search response
docs: keep the API doc up-to-date with recent changes

PiperOrigin-RevId: 522675951

Source-Link: googleapis/googleapis@f149e91

Source-Link: googleapis/googleapis-gen@c4538a8
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzQ1MzhhODg4ZDJlYzEzY2U3MTljMWExYWE5ZGM3ZGU1YjE3Mzc1YSJ9

feat: support per-entity search and autocomplete
feat: add model get API
feat: support new filter syntax for recommendation
feat: expose A/B experiment info in search response
docs: keep the API doc up-to-date with recent changes

PiperOrigin-RevId: 522675546

Source-Link: googleapis/googleapis@81b0808

Source-Link: googleapis/googleapis-gen@e950439
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTk1MDQzOWNkMGQ0ODZhYjhkMmIzMjY3MmI1NGMwYTZiNjQ1MTQyMCJ9

feat: Add support for updating additional pod IPv4 ranges for Standard and Autopilot clusters

Users can append more pod ranges by name to an existing cluster at the cluster level. When users or Node Auto-provisioning create new node pools, GKE will select the most available pod range and assign it to the node pool. These pod ranges can be removed once no node pool is using it.

PiperOrigin-RevId: 522620935

Source-Link: googleapis/googleapis@2ddfcb8

Source-Link: googleapis/googleapis-gen@8c7eccd
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOGM3ZWNjZDA5N2I3OTg5ZDcyY2FlOTU1ZmFmNWVkOGUzZmRjYmM3NSJ9

chore: disable Go compute targets (#794)

Source-Link: googleapis/googleapis@cc293c6

Source-Link: googleapis/googleapis-gen@6bb5382
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNmJiNTM4MmFiM2NkMzIyY2MxMjI4ZWI1ODdhZGI1ZTEyMzVjNWJkMyJ9

fix: add diregapic flag for compute (#793)

Source-Link: googleapis/googleapis@f9702dc

Source-Link: googleapis/googleapis-gen@2d6c055
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMmQ2YzA1NWYwMTY0NmMxNjM5MTAwZDk5MjJiMjdhOTg5MGJmMmM2NiJ9

chore: add Go build targets for compute (#792)

Note: manually updated proto file, but it yields the same result of the new disco-converter would generate.

Fixes: #7345
Source-Link: googleapis/googleapis@59828ba

Source-Link: googleapis/googleapis-gen@2649582
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjY0OTU4MjU3YzUzNTJkYjBiYzkxMGMwMGYxNDdiODIxYjAxMDYzNiJ9

chore: update gapic-generator-go version to 0.35.4
chore: add snippets to BUILD.bazel go_gapic_assembly_pkg

PiperOrigin-RevId: 522373543

Source-Link: googleapis/googleapis@130f097

Source-Link: googleapis/googleapis-gen@7d1457a
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiN2QxNDU3YWJlYzJmMGQyMDVmZGE2NzNhNGU2NTA4YjQxZGMxZTYzMSJ9

feat: Launch UploadConversation endpoint

PiperOrigin-RevId: 522129764

Source-Link: googleapis/googleapis@dabc235

Source-Link: googleapis/googleapis-gen@5609ad0
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTYwOWFkMDg4Y2NmMTVhMWMyMmRmN2FhZWIzMTMzZmJlYTU2Nzk5ZSJ9

feat: add support for disabling pod IP cidr overprovision

This feature requires special allowlisting for the projects.

PiperOrigin-RevId: 522103451

Source-Link: googleapis/googleapis@013b597

Source-Link: googleapis/googleapis-gen@2fe6962
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMmZlNjk2MmY5YzhlNzcwMzk2ZGNmYzg4ZTEwNGU1ZDcxM2MyZTY2ZSJ9

feat: added ignore_dependent_resources to DeleteCaPoolRequest, DeleteCertificateAuthorityRequest, DisableCertificateAuthorityRequest

PiperOrigin-RevId: 522096199

Source-Link: googleapis/googleapis@d9592ed

Source-Link: googleapis/googleapis-gen@0ab428e
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGFiNDI4ZTM5MzQ5ODFkYjljOGM3YmYxN2IxZmVhNWQ3NDY4MmFmYiJ9
gcf-owl-bot bot added a commit that referenced this issue Apr 10, 2023
feat: support per-entity search and autocomplete
feat: support new filter syntax for recommendation
feat: expose A/B experiment info in search response
docs: keep the API doc up-to-date with recent changes

PiperOrigin-RevId: 522675951

Source-Link: googleapis/googleapis@f149e91

Source-Link: googleapis/googleapis-gen@c4538a8
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzQ1MzhhODg4ZDJlYzEzY2U3MTljMWExYWE5ZGM3ZGU1YjE3Mzc1YSJ9

feat: support per-entity search and autocomplete
feat: add model get API
feat: support new filter syntax for recommendation
feat: expose A/B experiment info in search response
docs: keep the API doc up-to-date with recent changes

PiperOrigin-RevId: 522675546

Source-Link: googleapis/googleapis@81b0808

Source-Link: googleapis/googleapis-gen@e950439
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTk1MDQzOWNkMGQ0ODZhYjhkMmIzMjY3MmI1NGMwYTZiNjQ1MTQyMCJ9

feat: Add support for updating additional pod IPv4 ranges for Standard and Autopilot clusters

Users can append more pod ranges by name to an existing cluster at the cluster level. When users or Node Auto-provisioning create new node pools, GKE will select the most available pod range and assign it to the node pool. These pod ranges can be removed once no node pool is using it.

PiperOrigin-RevId: 522620935

Source-Link: googleapis/googleapis@2ddfcb8

Source-Link: googleapis/googleapis-gen@8c7eccd
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOGM3ZWNjZDA5N2I3OTg5ZDcyY2FlOTU1ZmFmNWVkOGUzZmRjYmM3NSJ9

chore: disable Go compute targets (#794)

Source-Link: googleapis/googleapis@cc293c6

Source-Link: googleapis/googleapis-gen@6bb5382
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNmJiNTM4MmFiM2NkMzIyY2MxMjI4ZWI1ODdhZGI1ZTEyMzVjNWJkMyJ9

fix: add diregapic flag for compute (#793)

Source-Link: googleapis/googleapis@f9702dc

Source-Link: googleapis/googleapis-gen@2d6c055
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMmQ2YzA1NWYwMTY0NmMxNjM5MTAwZDk5MjJiMjdhOTg5MGJmMmM2NiJ9

chore: add Go build targets for compute (#792)

Note: manually updated proto file, but it yields the same result of the new disco-converter would generate.

Fixes: #7345
Source-Link: googleapis/googleapis@59828ba

Source-Link: googleapis/googleapis-gen@2649582
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjY0OTU4MjU3YzUzNTJkYjBiYzkxMGMwMGYxNDdiODIxYjAxMDYzNiJ9

chore: update gapic-generator-go version to 0.35.4
chore: add snippets to BUILD.bazel go_gapic_assembly_pkg

PiperOrigin-RevId: 522373543

Source-Link: googleapis/googleapis@130f097

Source-Link: googleapis/googleapis-gen@7d1457a
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiN2QxNDU3YWJlYzJmMGQyMDVmZGE2NzNhNGU2NTA4YjQxZGMxZTYzMSJ9

feat: Launch UploadConversation endpoint

PiperOrigin-RevId: 522129764

Source-Link: googleapis/googleapis@dabc235

Source-Link: googleapis/googleapis-gen@5609ad0
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTYwOWFkMDg4Y2NmMTVhMWMyMmRmN2FhZWIzMTMzZmJlYTU2Nzk5ZSJ9

feat: add support for disabling pod IP cidr overprovision

This feature requires special allowlisting for the projects.

PiperOrigin-RevId: 522103451

Source-Link: googleapis/googleapis@013b597

Source-Link: googleapis/googleapis-gen@2fe6962
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMmZlNjk2MmY5YzhlNzcwMzk2ZGNmYzg4ZTEwNGU1ZDcxM2MyZTY2ZSJ9

feat: added ignore_dependent_resources to DeleteCaPoolRequest, DeleteCertificateAuthorityRequest, DisableCertificateAuthorityRequest

PiperOrigin-RevId: 522096199

Source-Link: googleapis/googleapis@d9592ed

Source-Link: googleapis/googleapis-gen@0ab428e
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGFiNDI4ZTM5MzQ5ODFkYjljOGM3YmYxN2IxZmVhNWQ3NDY4MmFmYiJ9
codyoss pushed a commit that referenced this issue Apr 10, 2023
feat: support per-entity search and autocomplete
feat: support new filter syntax for recommendation
feat: expose A/B experiment info in search response
docs: keep the API doc up-to-date with recent changes

PiperOrigin-RevId: 522675951

Source-Link: googleapis/googleapis@f149e91

Source-Link: googleapis/googleapis-gen@c4538a8
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzQ1MzhhODg4ZDJlYzEzY2U3MTljMWExYWE5ZGM3ZGU1YjE3Mzc1YSJ9
BEGIN_NESTED_COMMIT
feat(retail): support per-entity search and autocomplete
feat: add model get API
feat: support new filter syntax for recommendation
feat: expose A/B experiment info in search response
docs: keep the API doc up-to-date with recent changes

PiperOrigin-RevId: 522675546

Source-Link: googleapis/googleapis@81b0808

Source-Link: googleapis/googleapis-gen@e950439
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTk1MDQzOWNkMGQ0ODZhYjhkMmIzMjY3MmI1NGMwYTZiNjQ1MTQyMCJ9
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat(container): Add support for updating additional pod IPv4 ranges for Standard and Autopilot clusters

Users can append more pod ranges by name to an existing cluster at the cluster level. When users or Node Auto-provisioning create new node pools, GKE will select the most available pod range and assign it to the node pool. These pod ranges can be removed once no node pool is using it.

PiperOrigin-RevId: 522620935

Source-Link: googleapis/googleapis@2ddfcb8

Source-Link: googleapis/googleapis-gen@8c7eccd
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOGM3ZWNjZDA5N2I3OTg5ZDcyY2FlOTU1ZmFmNWVkOGUzZmRjYmM3NSJ9
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
chore(compute): disable Go compute targets (#794)

Source-Link: googleapis/googleapis@cc293c6

Source-Link: googleapis/googleapis-gen@6bb5382
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNmJiNTM4MmFiM2NkMzIyY2MxMjI4ZWI1ODdhZGI1ZTEyMzVjNWJkMyJ9
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
fix(compute): add diregapic flag for compute (#793)

Source-Link: googleapis/googleapis@f9702dc

Source-Link: googleapis/googleapis-gen@2d6c055
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMmQ2YzA1NWYwMTY0NmMxNjM5MTAwZDk5MjJiMjdhOTg5MGJmMmM2NiJ9
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
chore(compute): add Go build targets for compute (#792)

Note: manually updated proto file, but it yields the same result of the new disco-converter would generate.

Fixes: #7345
Source-Link: googleapis/googleapis@59828ba

Source-Link: googleapis/googleapis-gen@2649582
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjY0OTU4MjU3YzUzNTJkYjBiYzkxMGMwMGYxNDdiODIxYjAxMDYzNiJ9
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
chore(workflows): update gapic-generator-go version to 0.35.4
chore: add snippets to BUILD.bazel go_gapic_assembly_pkg

PiperOrigin-RevId: 522373543

Source-Link: googleapis/googleapis@130f097

Source-Link: googleapis/googleapis-gen@7d1457a
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiN2QxNDU3YWJlYzJmMGQyMDVmZGE2NzNhNGU2NTA4YjQxZGMxZTYzMSJ9
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat(contactcenterinsights): Launch UploadConversation endpoint

PiperOrigin-RevId: 522129764

Source-Link: googleapis/googleapis@dabc235

Source-Link: googleapis/googleapis-gen@5609ad0
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTYwOWFkMDg4Y2NmMTVhMWMyMmRmN2FhZWIzMTMzZmJlYTU2Nzk5ZSJ9
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat(container): add support for disabling pod IP cidr overprovision

This feature requires special allowlisting for the projects.

PiperOrigin-RevId: 522103451

Source-Link: googleapis/googleapis@013b597

Source-Link: googleapis/googleapis-gen@2fe6962
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMmZlNjk2MmY5YzhlNzcwMzk2ZGNmYzg4ZTEwNGU1ZDcxM2MyZTY2ZSJ9
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat(security/privateca): added ignore_dependent_resources to DeleteCaPoolRequest, DeleteCertificateAuthorityRequest, DisableCertificateAuthorityRequest

PiperOrigin-RevId: 522096199

Source-Link: googleapis/googleapis@d9592ed

Source-Link: googleapis/googleapis-gen@0ab428e
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGFiNDI4ZTM5MzQ5ODFkYjljOGM3YmYxN2IxZmVhNWQ3NDY4MmFmYiJ9
END_NESTED_COMMIT
gcf-owl-bot bot added a commit that referenced this issue Apr 10, 2023
Followup to #794 now that the Go generator has been patched
Source-Link: googleapis/googleapis@2954139

Source-Link: googleapis/googleapis-gen@bcb74f7
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYmNiNzRmNzNlZjk0NGU4MWMyNDNlNDNmZTJhMmE2YmNiMjA0ZTJhMiJ9
gcf-merge-on-green bot pushed a commit that referenced this issue Apr 10, 2023
- [ ] Regenerate this pull request now.

Followup to #794 now that the Go generator has been patched
Source-Link: https://togithub.com/googleapis/googleapis/commit/2954139219b05e346f3d046a1e691214b7d9f7de

Source-Link: https://togithub.com/googleapis/googleapis-gen/commit/bcb74f73ef944e81c243e43fe2a2a6bcb204e2a2
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYmNiNzRmNzNlZjk0NGU4MWMyNDNlNDNmZTJhMmE2YmNiMjA0ZTJhMiJ9
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the Datastore API.
Projects
None yet
Development

No branches or pull requests

1 participant