Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bigtable): Add quotes to end of range #10488

Merged
merged 2 commits into from
Jul 3, 2024
Merged

fix(bigtable): Add quotes to end of range #10488

merged 2 commits into from
Jul 3, 2024

Conversation

bhshkh
Copy link
Contributor

@bhshkh bhshkh commented Jul 2, 2024

Fixes: #9448

Issue:

While converting the range to string, the end bound does not have quotes. E.g.

	closed := NewClosedRange("row-01", "row-05")
	fmt.Println(closed)

prints:

["row-01",row-05]

Cause:
Endbound was not quoted

Fix:
Add quotes to end bound
Now, it prints:

["row-01","row-05"]

@bhshkh bhshkh marked this pull request as ready for review July 2, 2024 23:05
@bhshkh bhshkh requested review from a team as code owners July 2, 2024 23:05
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Jul 2, 2024
@bhshkh bhshkh enabled auto-merge (squash) July 3, 2024 18:12
@bhshkh bhshkh merged commit 142b153 into googleapis:main Jul 3, 2024
8 of 10 checks passed
@bhshkh bhshkh deleted the fix/cbt-issue-9448 branch July 3, 2024 18:18
@release-please release-please bot mentioned this pull request Jul 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkevinzheng gkevinzheng gkevinzheng approved these changes

Assignees
No one assigned
Labels
api: bigtable Issues related to the Bigtable API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bigtable: rowFilter.String() v1.21.0 do not include quotes in the endBound part
2 participants
@bhshkh @gkevinzheng