fix(bigtable): Add quotes to end of range (#10488)

googleapis · Jul 3, 2024 · 142b153 · 142b153
1 parent 0d0e5dd
commit 142b153
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/bigtable/bigtable.go b/bigtable/bigtable.go
@@ -624,9 +624,9 @@ func (r RowRange) String() string {
 	var endStr string
 	switch r.endBound {
 	case rangeOpen:
-		endStr = r.end + ")"
+		endStr = strconv.Quote(r.end) + ")"
 	case rangeClosed:
-		endStr = r.end + "]"
+		endStr = strconv.Quote(r.end) + "]"
 	case rangeUnbounded:
 		endStr = "∞)"
 	}

diff --git a/bigtable/bigtable_test.go b/bigtable/bigtable_test.go
@@ -513,22 +513,22 @@ func TestRowRangeString(t *testing.T) {
 		{
 			desc: "RowRange closed open",
 			rr:   NewClosedOpenRange("a", "b"),
-			str:  "[\"a\",b)",
+			str:  "[\"a\",\"b\")",
 		},
 		{
 			desc: "RowRange open open",
 			rr:   NewOpenRange("c", "d"),
-			str:  "(\"c\",d)",
+			str:  "(\"c\",\"d\")",
 		},
 		{
 			desc: "RowRange closed closed",
 			rr:   NewClosedRange("e", "f"),
-			str:  "[\"e\",f]",
+			str:  "[\"e\",\"f\"]",
 		},
 		{
 			desc: "RowRange open closed",
 			rr:   NewOpenClosedRange("g", "h"),
-			str:  "(\"g\",h]",
+			str:  "(\"g\",\"h\"]",
 		},
 		{
 			desc: "RowRange unbound unbound",
@@ -543,7 +543,7 @@ func TestRowRangeString(t *testing.T) {
 		{
 			desc: "RowRange unbound closed",
 			rr:   InfiniteReverseRange("c"),
-			str:  "(∞,c]",
+			str:  "(∞,\"c\"]",
 		},
 	} {
 		t.Run(test.desc, func(t *testing.T) {