Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Stop using message strings to determine if an error message "session expired" #10621

Merged
merged 1 commit into from
Jul 7, 2023
Merged

chore: Stop using message strings to determine if an error message "session expired" #10621

merged 1 commit into from
Jul 7, 2023

Conversation

jskeet
Copy link
Collaborator

@jskeet jskeet commented Jul 6, 2023

Fixes #10620.

@jskeet jskeet requested a review from a team as a code owner July 6, 2023 13:36
@jskeet
Copy link
Collaborator Author

jskeet commented Jul 6, 2023

Running integration tests (and then snippet tests) locally.

@jskeet
Copy link
Collaborator Author

jskeet commented Jul 6, 2023

Running the tests, I'm seeing a bunch of warnings:

[xUnit.net 00:00:05.65] Google.Cloud.Spanner.Data.IntegrationTests: Skipping test case with duplicate ID '6df5c686299207d93e6e83625b30587e88a14c50' ('Google.Cloud.Spanner.Data.IntegrationTests.DateTimestampReadTests.WriteDateThenRead_ShouldBeEqual_UseSpannerDateAndDateTime(writeAsDateTime: True, readAsDateTime: True, expectedDate: 2020-12-29T00:00:00.0000000+00:00)' and 'Google.Cloud.Spanner.Data.IntegrationTests.DateTimestampReadTests.WriteDateThenRead_ShouldBeEqual_UseSpannerDateAndDateTime(writeAsDateTime: True, readAsDateTime: True, expectedDate: 2020-12-29T00:00:00.0000000+00:00)')

Will investigate that separately.

@jskeet
Copy link
Collaborator Author

jskeet commented Jul 6, 2023

Snippets and integration tests pass.

amanda-tarafa
amanda-tarafa approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@amanda-tarafa amanda-tarafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jskeet jskeet merged commit db2a328 into googleapis:main Jul 7, 2023
9 checks passed
@jskeet jskeet deleted the spanner-session-not-found branch July 7, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amanda-tarafa amanda-tarafa amanda-tarafa approved these changes

Assignees

@amanda-tarafa amanda-tarafa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use machine-readable errors for Spanner "Session not found"
2 participants
@jskeet @amanda-tarafa