Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use machine-readable errors for Spanner "Session not found" #10620

Closed
jskeet opened this issue Jul 6, 2023 · 0 comments · Fixed by #10621
Closed

Use machine-readable errors for Spanner "Session not found" #10620

jskeet opened this issue Jul 6, 2023 · 0 comments · Fixed by #10621
Assignees
@jskeet
Labels
api: spanner Issues related to the Spanner API. type: cleanup An internal cleanup or hygiene concern.

Comments

@jskeet
Copy link
Collaborator

jskeet commented Jul 6, 2023

The code in apis/Google.Cloud.Spanner.V1/Google.Cloud.Spanner.V1/Internal/ExecuteHelper.cs uses an error message of "Session not found" to detect session expiry. We should use the machine-readable form, as Java does here.
@jskeet jskeet added api: spanner Issues related to the Spanner API. type: cleanup An internal cleanup or hygiene concern. labels Jul 6, 2023
@jskeet jskeet self-assigned this Jul 6, 2023
jskeet added a commit to jskeet/google-cloud-dotnet that referenced this issue Jul 6, 2023
@jskeet
chore: Stop using message strings to determine if an error message "s…
d9e921d 
…ession expired"

Fixes googleapis#10620.
@jskeet jskeet mentioned this issue Jul 6, 2023
Merged
jskeet added a commit that referenced this issue Jul 7, 2023
@jskeet
chore: Stop using message strings to determine if an error message "s…
db2a328 
…ession expired"

Fixes #10620.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jskeet jskeet

Labels
api: spanner Issues related to the Spanner API. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
1 participant
@jskeet