Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log or write exceptions thrown in the TimedBuffer #2182

Closed
iantalarico opened this issue May 24, 2018 · 2 comments · Fixed by #9805
Closed

Log or write exceptions thrown in the TimedBuffer #2182

iantalarico opened this issue May 24, 2018 · 2 comments · Fixed by #9805
Assignees
@amanda-tarafa
Labels
api: logging Issues related to the Cloud Logging API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@iantalarico
Copy link
Contributor

See https://github.com/GoogleCloudPlatform/google-cloud-dotnet/blob/master/apis/Google.Cloud.Diagnostics.Common/Google.Cloud.Diagnostics.Common/TimedBufferingConsumer.cs#L53
@evildour evildour mentioned this issue May 24, 2018
Merged
@jskeet jskeet added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label May 31, 2018
@amanda-tarafa
Copy link
Contributor

Moving to the backlog as we don't have a good solution for where to log these.

@erdalsivri erdalsivri mentioned this issue Jan 8, 2019
Closed
@amanda-tarafa amanda-tarafa mentioned this issue Jun 6, 2022
Closed
@amanda-tarafa
Copy link
Contributor

See #8556 for a recent request around this issue.

We can add a TimedBuffer specific option/action to indicate what to do with exceptions thrown inside the timer thread. We'll re-evaluate.

@amanda-tarafa amanda-tarafa reopened this Jun 6, 2022
@amanda-tarafa amanda-tarafa added the priority: p3 Desirable enhancement or fix. May not be included in next release. label Jun 6, 2022
@amanda-tarafa amanda-tarafa added the api: logging Issues related to the Cloud Logging API. label Jun 6, 2022
amanda-tarafa added a commit to amanda-tarafa/google-cloud-dotnet that referenced this issue Feb 1, 2023
@amanda-tarafa
feat: Allow handling of timer thread exceptions in timed buffers.
4cf75e8 
Closes googleapis#2182
@amanda-tarafa amanda-tarafa mentioned this issue Feb 1, 2023
Merged
amanda-tarafa added a commit to amanda-tarafa/google-cloud-dotnet that referenced this issue Feb 2, 2023
@amanda-tarafa
feat: Allow handling of timer thread exceptions in timed buffers.
9cd730e 
Closes googleapis#2182
amanda-tarafa added a commit that referenced this issue Feb 2, 2023
@amanda-tarafa
feat: Allow handling of timer thread exceptions in timed buffers.
957f4b4 
Closes #2182
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amanda-tarafa amanda-tarafa

Labels
api: logging Issues related to the Cloud Logging API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Allow handling of timer thread exceptions in timed buffers. amanda-tarafa/google-cloud-dotnet
3 participants
@jskeet @iantalarico @amanda-tarafa