Release of Google.Cloud.Diagnostics.* 2.0.1 #2181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evildour
reviewed
May 24, 2018
| @@ -48,12 +48,10 @@ internal TimedBufferingConsumer(IConsumer<T> consumer, TimeSpan waitTime, IThrea | |||
| { | |||
| Flush(); | |||
| } | |||
| catch (RpcException) | |||
| catch (Exception) | |||
| { | |||
| // TODO(talarico): This is a short term solution to ensure | |||
| // we do not kill a process. See issue #842 to track the long term solution. | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
evildour
approved these changes
May 24, 2018
|
Thanks Mike! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catch all Exceptions in the TimedBuffer timer to avoid ever bringing down an application.
I ran all the integration and unit tests and all is good. I'm going to have to release manually as I don't think the current deployment can handle the older scripts.